Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5855)

Unified Diff: chrome/browser/extensions/chrome_extensions_browser_client.cc

Issue 1254103002: New Task Manager - Phase 1.3.5: Implement Extension Task Providing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Devlin's comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_extensions_browser_client.cc
diff --git a/chrome/browser/extensions/chrome_extensions_browser_client.cc b/chrome/browser/extensions/chrome_extensions_browser_client.cc
index c19dad979f5ca5b338912ad7a3311655d22cfaa1..eace973060beecbed31332b2ddf0e871c86576f6 100644
--- a/chrome/browser/extensions/chrome_extensions_browser_client.cc
+++ b/chrome/browser/extensions/chrome_extensions_browser_client.cc
@@ -30,6 +30,7 @@
#include "chrome/browser/net/chrome_net_log.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/task_management/web_contents_tags.h"
#include "chrome/common/channel_info.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
@@ -337,4 +338,36 @@ void ChromeExtensionsBrowserClient::CleanUpWebView(
MenuItem::ExtensionKey("", embedder_process_id, view_instance_id));
}
+void ChromeExtensionsBrowserClient::AttachExtensionTaskManagerTag(
+ content::WebContents* web_contents,
+ ViewType view_type) {
+ switch (view_type) {
+ case VIEW_TYPE_APP_WINDOW:
+ case VIEW_TYPE_EXTENSION_BACKGROUND_PAGE:
+ case VIEW_TYPE_EXTENSION_DIALOG:
+ case VIEW_TYPE_EXTENSION_POPUP:
+ case VIEW_TYPE_LAUNCHER_PAGE:
+ case VIEW_TYPE_VIRTUAL_KEYBOARD:
+ // These are the only types that are tracked by the ExtensionTag.
+ task_management::WebContentsTags::CreateForExtension(web_contents,
+ view_type);
+ return;
+
+ case VIEW_TYPE_BACKGROUND_CONTENTS:
+ case VIEW_TYPE_PANEL:
+ case VIEW_TYPE_TAB_CONTENTS:
+ // Those types are tracked by other tags:
+ // BACKGROUND_CONTENTS --> task_management::BackgroundContentsTag.
+ // PANEL --> task_management::PanelTag.
+ // TAB_CONTENTS --> task_management::TabContentsTag.
+ // These tags are created and attached to the web_contents in other
+ // locations, and they must be ignored here.
+ return;
+
+ case VIEW_TYPE_INVALID:
+ NOTREACHED();
+ return;
+ }
+}
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698