New Task Manager - Phase 1.3.5: Implement Extension Task Providing

chrome/browser/task_management/providers/web_contents/extension_task.cc

Index: chrome/browser/task_management/providers/web_contents/extension_task.cc
diff --git a/chrome/browser/task_management/providers/web_contents/extension_task.cc b/chrome/browser/task_management/providers/web_contents/extension_task.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6f3e2a07cfc189a45bc669f1a5af501a6c97368f
--- /dev/null
+++ b/chrome/browser/task_management/providers/web_contents/extension_task.cc
@@ -0,0 +1,81 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/task_management/providers/web_contents/extension_task.h"
+
+#include "base/strings/utf_string_conversions.h"
+#include "content/public/browser/browser_context.h"
+#include "content/public/browser/web_contents.h"
+#include "extensions/browser/view_type_utils.h"
+#include "extensions/common/extension.h"
+#include "extensions/common/view_type.h"
+#include "grit/theme_resources.h"
+#include "ui/base/resource/resource_bundle.h"
+
+namespace task_management {
+
+namespace {
+
+gfx::ImageSkia* g_default_icon = nullptr;
+
+gfx::ImageSkia* GetDefaultIcon() {
+  if (!g_default_icon && ResourceBundle::HasSharedInstance()) {
+    g_default_icon = ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
+        IDR_EXTENSIONS_FAVICON);
+  }
+
+  return g_default_icon;
+}
+
+}  // namespace
+
+ExtensionTask::ExtensionTask(content::WebContents* web_contents,
+                             const extensions::Extension* extension,
+                             extensions::ViewType view_type)
+    : RendererTask(GetExtensionTitle(web_contents, extension, view_type),
+                   GetDefaultIcon(),
+                   web_contents) {
+}
+
+ExtensionTask::~ExtensionTask() {
+}
+
+void ExtensionTask::OnTitleChanged(content::NavigationEntry* entry) {
+  // The title of the extension should not change as a result of title change
+  // in its WebContents, so we ignore this.
+}
+
+void ExtensionTask::OnFaviconChanged() {
+  // We never change the favicon of the extension, we always use the default

[Devlin, 2015/08/06 17:43:44]

Can you add a TODO to use the extension's icon, just so it doesn't get lost?

[afakhry, 2015/08/06 18:01:27]

Done.

+  // one.
+}
+
+Task::Type ExtensionTask::GetType() const {
+  return Task::EXTENSION;
+}
+
+base::string16 ExtensionTask::GetExtensionTitle(
+    content::WebContents* web_contents,
+    const extensions::Extension* extension,
+    extensions::ViewType view_type) const {
+  DCHECK(web_contents);
+
+  base::string16 title;

[Devlin, 2015/08/06 17:43:44]

nit: ternaries are nice. :)
base::string16 title = extension ?
    base::UTF8ToUTF16(extension->name()) :
    RendererTask::GetTitleFromWebContents(web_contents);

[afakhry, 2015/08/06 18:01:27]

Absolutely! Thanks! :)
Done.

+  if (extension)
+    title = base::UTF8ToUTF16(extension->name());
+  else
+    title = RendererTask::GetTitleFromWebContents(web_contents);
+
+  bool is_background =
+      view_type == extensions::VIEW_TYPE_EXTENSION_BACKGROUND_PAGE;
+
+  return RendererTask::PrefixRendererTitle(
+      title,
+      extension->is_app(),
+      true,  // is_extension
+      web_contents->GetBrowserContext()->IsOffTheRecord(),
+      is_background);
+}
+
+}  // namespace task_management