New Task Manager - Phase 1.3.5: Implement Extension Task Providing

chrome/browser/task_management/providers/web_contents/renderer_task.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_TASK_MANAGEMENT_PROVIDERS_WEB_CONTENTS_RENDERER_TASK_H_
 #define CHROME_BROWSER_TASK_MANAGEMENT_PROVIDERS_WEB_CONTENTS_RENDERER_TASK_H_
 
 #include "chrome/browser/task_management/providers/task.h"
 #include "content/public/browser/navigation_entry.h"
 
@@ skipping 41 matching lines @@
   // Returns the title of the given |web_contents|.
   static base::string16 GetTitleFromWebContents(
       content::WebContents* web_contents);
 
   // Returns the favicon of the given |web_contents| if any, and returns
   // |nullptr| otherwise.
   static const gfx::ImageSkia* GetFaviconFromWebContents(
       content::WebContents* web_contents);
 
   // Prefixes the given renderer |title| with the appropriate string based on
-  // whether it's an app, an extension, or incognito.
+  // whether it's an app, an extension, incognito or a background.

[Devlin, 2015/08/04 16:05:07]

"a background"?  We should probably be more clear about what that means.

[afakhry, 2015/08/04 18:31:08]

background here means either view type of BACKGROUND_CONTENTS or
BACKGROUND_PAGE.

   static const base::string16 PrefixRendererTitle(const base::string16& title,
                                                   bool is_app,

[Devlin, 2015/08/04 16:05:07]

the fact that we have is_app and is_extension is weird to me.  If you're up for
a change (possibly in a follow-up), this would probably be a lot cleaner if we
passed in an enum.  But, not directly related to this change.

[afakhry, 2015/08/04 18:31:08]

I'm not sure I totally get your suggestion here. However, I will defer
commenting on this to Nick, because this is how the old task manager used to do
the prefix. I remember Nick telling me about the desire to have the WebContents'
app-ness take precedence over its extension-ness and tab-ness.

[ncarter (slow), 2015/08/04 18:55:19]

I think devlin means that "app && !extension" ought to be nonsensical, and
replacing the pair of bools with a a tri-state enum would eliminate that case.
Which I agree with. But given how the code flows, I this function might actually
be a tad easier to call with two bools -- unless there's an existing tri-state
enum that we leverage. Note that is_background also implies is_extension, so
there are other nonsensical ways to call this function, but that's probably
okay; we return something reasonable in those cases too.

[afakhry, 2015/08/04 19:02:25]

I got it. We can definitely defer this to a later change.

                                                   bool is_extension,
-                                                  bool is_incognito);
+                                                  bool is_incognito,
+                                                  bool is_background);
 
   content::WebContents* web_contents() const { return web_contents_; }
 
  private:
   // The WebContents of the task this object represents.
   content::WebContents* web_contents_;
 
   // The render process host of the task this object represents.
   content::RenderProcessHost* render_process_host_;
 
@@ skipping 15 matching lines @@
   // The profile name associated with the browser context of the render view
   // host.
   const base::string16 profile_name_;
 
   DISALLOW_COPY_AND_ASSIGN(RendererTask);
 };
 
 }  // namespace task_management
 
 #endif  // CHROME_BROWSER_TASK_MANAGEMENT_PROVIDERS_WEB_CONTENTS_RENDERER_TASK_H_