New Task Manager - Phase 1.3.5: Implement Extension Task Providing

chrome/browser/task_management/providers/web_contents/panel_task.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/task_management/providers/web_contents/panel_task.h"
 
 #include "base/i18n/rtl.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/panels/panel.h"
 #include "extensions/browser/extension_registry.h"
@@ skipping 35 matching lines @@
 
 base::string16 PanelTask::GetCurrentPanelTitle(Panel* panel) const {
   base::string16 title = panel->GetWindowTitle();
   base::i18n::AdjustStringForLocaleDirection(&title);
 
   extensions::ExtensionRegistry* registry =
       extensions::ExtensionRegistry::Get(panel->profile());
   const extensions::Extension* extension =
       registry->enabled_extensions().GetByID(panel->extension_id());
 
   const bool is_app = extension ? extension->is_app() : false;

[Devlin, 2015/08/04 16:05:07]

drive-by: this would be cleaner as is_app = extension && extension->is_app(). :)

[afakhry, 2015/08/04 18:31:08]

Much better, really! Thanks! :) 
Done.

   const bool is_incognito = panel->profile()->IsOffTheRecord();
 
   return PrefixRendererTitle(title,
                              is_app,
                              true,  // is_extension.
-                             is_incognito);
+                             is_incognito,
+                             false);  // is_background.
 }
 
 }  // namespace task_management