New Task Manager - Phase 1.3.5: Implement Extension Task Providing

chrome/browser/extensions/chrome_extensions_browser_client.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/chrome_extensions_browser_client.h"
 
 #include "base/command_line.h"
 #include "base/version.h"
 #include "chrome/browser/app_mode/app_mode_utils.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 13 matching lines @@
 #include "chrome/browser/extensions/chrome_url_request_util.h"
 #include "chrome/browser/extensions/error_console/error_console.h"
 #include "chrome/browser/extensions/event_router_forwarder.h"
 #include "chrome/browser/extensions/extension_system_factory.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/extensions/menu_manager.h"
 #include "chrome/browser/external_protocol/external_protocol_handler.h"
 #include "chrome/browser/net/chrome_net_log.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/task_management/web_contents_tags.h"
 #include "chrome/common/channel_info.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/features/feature_channel.h"
 #include "chrome/common/pref_names.h"
 #include "components/version_info/version_info.h"
 #include "content/public/browser/render_process_host.h"
 #include "extensions/browser/api/generated_api_registration.h"
 #include "extensions/browser/extension_function_registry.h"
 #include "extensions/browser/extension_prefs.h"
@@ skipping 294 matching lines @@
       content::RenderProcessHost::FromID(embedder_process_id)
       ->GetBrowserContext();
 
   // Clean up context menus for the WebView.
   auto menu_manager =
       MenuManager::Get(Profile::FromBrowserContext(browser_context));
   menu_manager->RemoveAllContextItems(
       MenuItem::ExtensionKey("", embedder_process_id, view_instance_id));
 }
 
+void ChromeExtensionsBrowserClient::AttachExtensionTaskManagerTag(
+    content::WebContents* web_contents,
+    ViewType view_type) {
+  switch (view_type) {
+    case VIEW_TYPE_APP_WINDOW:
+    case VIEW_TYPE_EXTENSION_BACKGROUND_PAGE:
+    case VIEW_TYPE_EXTENSION_DIALOG:
+    case VIEW_TYPE_EXTENSION_POPUP:
+    case VIEW_TYPE_LAUNCHER_PAGE:
+    case VIEW_TYPE_VIRTUAL_KEYBOARD:
+      // These are the only types that are tracked by the ExtensionTag.
+      task_management::WebContentsTags::CreateForExtension(web_contents);
+      return;
+
+    case VIEW_TYPE_INVALID:
+    case VIEW_TYPE_BACKGROUND_CONTENTS:
+    case VIEW_TYPE_PANEL:
+    case VIEW_TYPE_TAB_CONTENTS:

[Devlin, 2015/08/04 16:05:07]

I think it would be good to document which tags these are (or will be) tracked
by.  Tab is obvious, but where does panel fall?

Also, do we really have one for invalid?  If so, that sounds like a bug.  If
not, I think we should NOTREACHED it.

[afakhry, 2015/08/04 18:31:07]

The PanelTag will be created in Panel::Initialize(). I added more comments.
Please let me know if they're still not obvious.

Done for the NOTREACHED() the invalid type.

+      // Those types are tracked by other tags, so they're ignored.
+      return;
+
+    default:

[Devlin, 2015/08/04 16:05:07]

Best to not have a default case.  That way, if we do add a new view type, we get
a compile error, rather than a runtime error.

[afakhry, 2015/08/04 18:31:07]

Done.

+      // Added new types that are possibly not tracked by the task manager.
+      NOTREACHED();
+      return;
+  }
+}
+
 }  // namespace extensions