New Task Manager - Phase 1.3.5: Implement Extension Task Providing

chrome/browser/extensions/chrome_extension_web_contents_observer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
 
 #include "chrome/browser/extensions/error_console/error_console.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/window_controller.h"
+#include "chrome/browser/task_management/web_contents_tags.h"
 #include "chrome/common/extensions/chrome_extension_messages.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/common/extension_messages.h"
 #include "extensions/common/extension_urls.h"
 
@@ skipping 57 matching lines @@
 }
 
 void ChromeExtensionWebContentsObserver::InitializeRenderFrame(
     content::RenderFrameHost* render_frame_host) {
   ExtensionWebContentsObserver::InitializeRenderFrame(render_frame_host);
   WindowController* controller = dispatcher()->GetExtensionWindowController();
   if (controller) {
     render_frame_host->Send(new ExtensionMsg_UpdateBrowserWindowId(
         render_frame_host->GetRoutingID(), controller->GetWindowId()));
   }
+
+  const Extension* extension = GetExtensionFromFrame(render_frame_host);
+  if (extension) {
+    // Make the extension show up in the task manager.
+    task_management::WebContentsTags::CreateForExtension(web_contents(),
+                                                         extension);

[afakhry, 2015/07/25 00:50:40]

Man, there must be a better place to do the tagging. Tagging here forced me to
have the condition that I don't like in WebContentsTags::CreateForExtension().

Other possible tagging places that are possibly covered by this one but they
might help us avoid potential collisions that result from tagging here:
1-
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/browser...

2-
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

3-
https://code.google.com/p/chromium/codesearch#chromium/src/apps/custom_launch...

4-
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/browser...

+  }
 }
 
 void ChromeExtensionWebContentsObserver::ReloadIfTerminated(
     content::RenderViewHost* render_view_host) {
   std::string extension_id = GetExtensionId(render_view_host);
   if (extension_id.empty())
     return;
 
   ExtensionRegistry* registry = ExtensionRegistry::Get(browser_context());
 
   // Reload the extension if it has crashed.
   // TODO(yoz): This reload doesn't happen synchronously for unpacked
   //            extensions. It seems to be fast enough, but there is a race.
   //            We should delay loading until the extension has reloaded.
   if (registry->GetExtensionById(extension_id, ExtensionRegistry::TERMINATED)) {
     ExtensionSystem::Get(browser_context())->
         extension_service()->ReloadExtension(extension_id);
   }
 }
 
 }  // namespace extensions