chrome/browser/ui/browser_navigator_browsertest.cc - Issue 12541018: Allow showing pending URL for new tab navigations, but only if safe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_navigator_browsertest.cc

Issue 12541018: Allow showing pending URL for new tab navigations, but only if safe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix Android test. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_navigator_browsertest.cc

diff --git a/chrome/browser/ui/browser_navigator_browsertest.cc b/chrome/browser/ui/browser_navigator_browsertest.cc

index 36c6de2a25a7f97319bdf4b00bebc7f2da4d5b75..186681ac01ffbcd3ab507efae8df4bd1d20af987 100644

--- a/chrome/browser/ui/browser_navigator_browsertest.cc

+++ b/chrome/browser/ui/browser_navigator_browsertest.cc

@@ -184,6 +184,8 @@ namespace {

// This test verifies that when a navigation occurs within a tab, the tab count

// of the Browser remains the same and the current tab bears the loaded URL.

+// Note that network URLs are not actually loaded in tests, so this also tests

+// that error pages leave the intended URL in the address bar.

IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest, Disposition_CurrentTab) {

ui_test_utils::NavigateToURL(browser(), GetGoogleURL());

EXPECT_EQ(GetGoogleURL(),