chrome/browser/external_extension_browsertest.cc - Issue 12541018: Allow showing pending URL for new tab navigations, but only if safe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/external_extension_browsertest.cc

Issue 12541018: Allow showing pending URL for new tab navigations, but only if safe. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix Android test. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/external_extension_browsertest.cc

diff --git a/chrome/browser/external_extension_browsertest.cc b/chrome/browser/external_extension_browsertest.cc

index a72421315dc97ec183ff68065bd96f719da48f31..3fdc0abd29ef84471521b030622a9b1c367d1e7c 100644

--- a/chrome/browser/external_extension_browsertest.cc

+++ b/chrome/browser/external_extension_browsertest.cc

@@ -58,7 +58,7 @@ class SearchProviderTest : public InProcessBrowserTest {

search_provider_test_url_.path() + "#" + expected_result);

ui_test_utils::NavigateToURLWithDisposition(

browser, test_url, NEW_FOREGROUND_TAB,

- ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB);

+ ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

// Bundle up information needed to verify the result.

content::WebContents* tab =