This adds the setProperties and getState functions to the networking API

chrome/browser/chromeos/extensions/networking_private_api.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/networking_private_api.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "chrome/browser/chromeos/net/managed_network_configuration_handler.h"
@@ skipping 45 matching lines @@
 }
 
 void NetworkingPrivateGetPropertiesFunction::GetPropertiesFailed(
     const std::string& error_name,
     scoped_ptr<base::DictionaryValue> error_data) {
   error_ = error_name;
   SendResponse(false);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
+// NetworkingPrivateGetStateFunction
+
+NetworkingPrivateGetStateFunction::
+  ~NetworkingPrivateGetStateFunction() {
+}
+
+bool NetworkingPrivateGetStateFunction::RunImpl() {
+  scoped_ptr<api::GetState::Params> params =
+      api::GetState::Params::Create(*args_);
+  EXTENSION_FUNCTION_VALIDATE(params);
+  // The |network_guid| parameter is storing the service path.
+  std::string service_path = params->network_guid;
+
+  const NetworkState* state =
+      NetworkStateHandler::Get()->GetNetworkState(service_path);
+  if (!state) {
+    error_ = "Error.InvalidParameter";

[stevenjb, 2013/03/07 00:43:22]

Should this be "InvalidParameter"? A network might have disconnected and be no
longer available.

[Greg Spencer (Chromium), 2013/03/07 22:01:23]

Well, my thought was that the service path was no longer valid, but if it can be
still valid and still get back NULL, then what should I return (i.e. how can I
distinguish between an invalid service path and a disconnected network)?

[stevenjb, 2013/03/08 19:04:16]

I guess I was thinking that the service could be "no longer available", which
isn't exactly the same as "invalid", but I guess it is impractical to
differentiate that (we'd have to track services that were available) and no real
practical difference between the two anyway.

+    SendResponse(false);
+  }
+
+  scoped_ptr<base::DictionaryValue> result_dict(new base::DictionaryValue);
+  state->FillDictionary(result_dict.get());

[pneubeck (no reviews), 2013/03/07 13:06:18]

|result_dict| has to be translated to ONC, since "FillDictionary" doesn't do
that anymore.
See line 155 on the right.

[Greg Spencer (Chromium), 2013/03/07 22:01:23]

Ahh, no wonder my results were off...

+  SetResult(result_dict.release());
+  SendResponse(true);
+
+  return true;
+}
+
+////////////////////////////////////////////////////////////////////////////////
+// NetworkingPrivateSetPropertiesFunction
+
+NetworkingPrivateSetPropertiesFunction::
+  ~NetworkingPrivateSetPropertiesFunction() {

[stevenjb, 2013/03/07 00:43:22]

No WS at beginning of line here I think

[Greg Spencer (Chromium), 2013/03/07 22:01:23]

OK. :-)  I don't think there's a lot of precedent for this, so I was kind of
winging it.  The whitespace felt to me like it was a continuation more than not
having it.

[stevenjb, 2013/03/08 19:04:16]

There's not a ton of precedent, but it's what I have seen and used before, and
is consistent with the Google Emacs formatting plugin :)

+}
+
+bool NetworkingPrivateSetPropertiesFunction::RunImpl() {
+  scoped_ptr<api::SetProperties::Params> params =
+      api::SetProperties::Params::Create(*args_);
+  EXTENSION_FUNCTION_VALIDATE(params);
+
+  scoped_ptr<base::DictionaryValue> properties_dict(
+      params->properties.ToValue());
+
+  ManagedNetworkConfigurationHandler::Get()->SetProperties(
+      params->network_guid,
+      *properties_dict,
+      base::Bind(&NetworkingPrivateSetPropertiesFunction::ResultCallback,
+                 this),
+      base::Bind(&NetworkingPrivateSetPropertiesFunction::ErrorCallback,
+                 this));
+  return true;
+}
+
+void NetworkingPrivateSetPropertiesFunction::ErrorCallback(
+    const std::string& error_name,
+    const scoped_ptr<base::DictionaryValue> error_data) {
+  error_ = error_name;
+  SendResponse(false);
+}
+
+void NetworkingPrivateSetPropertiesFunction::ResultCallback() {
+  SendResponse(true);
+}
+
+////////////////////////////////////////////////////////////////////////////////
 // NetworkingPrivateGetVisibleNetworksFunction
 
 NetworkingPrivateGetVisibleNetworksFunction::
 ~NetworkingPrivateGetVisibleNetworksFunction() {
 }
 
 bool NetworkingPrivateGetVisibleNetworksFunction::RunImpl() {
   scoped_ptr<api::GetVisibleNetworks::Params> params =
       api::GetVisibleNetworks::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(params);
@@ skipping 221 matching lines @@
     const std::string& result) {
   results_ = api::VerifyAndEncryptData::Results::Create(result);
   SendResponse(true);
 }
 
 void NetworkingPrivateVerifyAndEncryptDataFunction::ErrorCallback(
     const std::string& error_name, const std::string& error) {
   error_ = error_name;
   SendResponse(false);
 }
+