Issue 1254073003: Tail call from TurboFan into select runtime calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1254073003: Tail call from TurboFan into select runtime calls (Closed)

Created:
5 years, 4 months ago by danno

Modified:
4 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Tail call from TurboFan into select runtime calls

Patch Set 1 #

Patch Set 2 : Smaller patch #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -0 lines)			Patch
M	src/compiler/js-context-relaxation.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/compiler/linkage-impl.h	View	2 chunks	+4 lines, -0 lines	1 comment	Download
M	src/runtime/runtime.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/runtime/runtime.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Starzinger

5 years, 4 months ago (2015-08-04 15:01:54 UTC) #3

https://codereview.chromium.org/1254073003/diff/20001/src/compiler/linkage-im...
File src/compiler/linkage-impl.h (right):

https://codereview.chromium.org/1254073003/diff/20001/src/compiler/linkage-im...
src/compiler/linkage-impl.h:123: if (Runtime::SupportsTailCall(function_id)) {
This new predicate on {Runtime} is similar to Linkage::FrameStateInputCount. Can
we move it to {Linkage} into the linkage.cc file for consistency? I agree that
this decouples it from the list of runtime functions (which might be
controversial), but we already went with that for the frame states, and I would
rather keep it consistent. WDYT?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages