Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1254023006: Move ServiceWorker public headers to public/{web,platform}/modules/serviceworker (2/3) (Closed)

Created:
5 years, 4 months ago by kinuko
Modified:
5 years, 4 months ago
Reviewers:
tkent, falken, Tom Sepez
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, mlamouri+watch-content_chromium.org, tzik, johnme+watch_chromium.org, serviceworker-reviews, jam, nhiroki, mvanouwerkerk+watch_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, horo+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+serviceworker, kinuko+watch, peter+watch_chromium.org, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ServiceWorker public headers to public/{web,platform}/modules/serviceworker (2/3) Three-sided patch: [1] (blink) https://codereview.chromium.org/1262943002/ [2] (chromium) THIS PATCH [3] (blink) https://codereview.chromium.org/1262603004/ BUG=453032 TBR=tsepez@chromium.org Committed: https://crrev.com/4b9f1ab41d471756c996e4651b049f3a75fea170 Cr-Commit-Position: refs/heads/master@{#344171}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 8

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -75 lines) Patch
M components/test_runner/test_runner.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/DEPS View 1 2 2 chunks +9 lines, -9 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/cache_storage/cache_storage_dispatcher_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_handle_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_metrics.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_registration_status.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/child/navigator_connect/service_port_dispatcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/service_worker_dispatcher.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/service_worker/web_service_worker_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/web_service_worker_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/web_service_worker_registration_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/web_service_worker_registration_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/DEPS View 1 2 3 chunks +10 lines, -10 lines 0 comments Download
M content/common/cache_storage/cache_storage_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/service_worker/service_worker_client_info.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/service_worker/service_worker_types.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M content/public/common/resource_response_info.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/cache_storage/cache_storage_dispatcher.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/cache_storage/cache_storage_dispatcher.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/cache_storage/webserviceworkercachestorage_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/cache_storage/webserviceworkercachestorage_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/push_messaging/push_messaging_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M content/renderer/service_worker/service_worker_type_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254023006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254023006/20001
5 years, 4 months ago (2015-08-14 03:51:37 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/88138)
5 years, 4 months ago (2015-08-14 04:00:17 UTC) #4
kinuko
Mechanical header change only. PTL
5 years, 4 months ago (2015-08-14 10:15:49 UTC) #6
tkent
lgtm https://codereview.chromium.org/1254023006/diff/20001/content/browser/DEPS File content/browser/DEPS (right): https://codereview.chromium.org/1254023006/diff/20001/content/browser/DEPS#newcode72 content/browser/DEPS:72: "+third_party/WebKit/public/web/mac/WebScrollbarTheme.h", Looks this is not in sorted position. ...
5 years, 4 months ago (2015-08-17 00:32:31 UTC) #7
falken
lgtm https://codereview.chromium.org/1254023006/diff/20001/content/child/service_worker/service_worker_dispatcher.cc File content/child/service_worker/service_worker_dispatcher.cc (right): https://codereview.chromium.org/1254023006/diff/20001/content/child/service_worker/service_worker_dispatcher.cc#newcode24 content/child/service_worker/service_worker_dispatcher.cc:24: #include "third_party/WebKit/public/platform/WebString.h" I believe platform/WebString comes after platform/modules/* ...
5 years, 4 months ago (2015-08-17 08:36:12 UTC) #8
kinuko
Thanks, updated. tsepez@: could you review messages changes? Actually I'm going to TBR this as ...
5 years, 4 months ago (2015-08-18 07:52:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254023006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254023006/40001
5 years, 4 months ago (2015-08-18 07:53:31 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_android/builds/42797) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 4 months ago (2015-08-18 08:06:41 UTC) #15
Tom Sepez
RS LGTM
5 years, 4 months ago (2015-08-18 14:53:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254023006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254023006/40001
5 years, 4 months ago (2015-08-19 02:42:58 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/86565)
5 years, 4 months ago (2015-08-19 02:45:17 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254023006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254023006/60001
5 years, 4 months ago (2015-08-19 06:02:01 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-08-19 07:26:08 UTC) #24
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 07:26:37 UTC) #25
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/4b9f1ab41d471756c996e4651b049f3a75fea170
Cr-Commit-Position: refs/heads/master@{#344171}

Powered by Google App Engine
This is Rietveld 408576698