Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1254023004: Revert of win 2015: Update the toolchain package to VS2015 RTM. (Closed)

Created:
5 years, 4 months ago by Sébastien Marchand
Modified:
5 years, 4 months ago
Reviewers:
Nico, brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of win 2015: Update the toolchain package to VS2015 RTM. (patchset #2 id:20001 of https://codereview.chromium.org/1265503002/) Reason for revert: It's breaking the VS2015 builder. I'm looking at it. Original issue's description: > win 2015: Update the toolchain package to VS2015 RTM. > > I've tried it locally (build Chrome with this archive on a fresh VM) and it worked well, the archive has been generated with package_from_installed.py (from depot_tools/win_toolchain) > > BUG= > > Committed: https://crrev.com/f04ff85d2b85833971ef7ca7f31f4fd5a1b1f3aa > Cr-Commit-Position: refs/heads/master@{#340898} TBR=brucedawson@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/ff200aeebf10796f772ea5ecc61ec1be9b7cdac3 Cr-Commit-Position: refs/heads/master@{#340906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/vs_toolchain.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Sébastien Marchand
Created Revert of win 2015: Update the toolchain package to VS2015 RTM.
5 years, 4 months ago (2015-07-29 17:03:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254023004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254023004/1
5 years, 4 months ago (2015-07-29 17:05:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-29 17:07:01 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 17:08:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff200aeebf10796f772ea5ecc61ec1be9b7cdac3
Cr-Commit-Position: refs/heads/master@{#340906}

Powered by Google App Engine
This is Rietveld 408576698