Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1254003004: Class block scoping tests (Closed)

Created:
5 years, 5 months ago by Dan Ehrenberg
Modified:
5 years, 5 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Class block scoping tests Class bindings are mutable and lexically scoped, with TDZ semantics. They may not overlap with var bindings in the same scope. This patch adds tests for those properties. R=adamk BUG=v8:3305 LOG=N Committed: https://crrev.com/024e39613a84c3c48796cc52cf52b4e85b2e337a Cr-Commit-Position: refs/heads/master@{#29856}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix style and flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
A test/mjsunit/harmony/block-scope-class.js View 1 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dan Ehrenberg
5 years, 5 months ago (2015-07-25 01:03:35 UTC) #1
adamk
lgtm % nits https://codereview.chromium.org/1254003004/diff/1/test/mjsunit/harmony/block-scope-class.js File test/mjsunit/harmony/block-scope-class.js (right): https://codereview.chromium.org/1254003004/diff/1/test/mjsunit/harmony/block-scope-class.js#newcode7 test/mjsunit/harmony/block-scope-class.js:7: // Flags: --no-legacy-const --harmony-sloppy What does ...
5 years, 5 months ago (2015-07-25 01:29:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254003004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254003004/20001
5 years, 5 months ago (2015-07-25 01:35:21 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-25 01:59:21 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-25 01:59:35 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/024e39613a84c3c48796cc52cf52b4e85b2e337a
Cr-Commit-Position: refs/heads/master@{#29856}

Powered by Google App Engine
This is Rietveld 408576698