Reintroduce --prompt-for-external-extensions flag on Chromium builds.

Reintroduce --prompt-for-external-extensions flag on Chromium builds.

On Chromium, this will allow tests to disable the opt-in prompt that appears after external extensions are installed.

BUG=513881
Committed: https://crrev.com/aa19ce5e62f69c5a8abc42e736d30b15aeee9794
Cr-Commit-Position: refs/heads/master@{#340812}

[sydli, 2015-07-24 22:26:30]

sydli@google.com changed reviewers:
+ asargent@chromium.org

[sydli, 2015-07-24 22:26:30]

+asargent@
does this look alright?

[sydli, 2015-07-27 21:25:42]

sydli@google.com changed reviewers:
+ erikchen@chromium.org, robliao@chromium.org

[sydli, 2015-07-27 21:37:09]

+erikchen and +robliao for review. this CL will enable tests on Windows (and
eventually Mac) to disable the opt-in prompt for automatically installed
extensions.

[erikchen, 2015-07-27 21:45:02]

lgtm

[robliao, 2015-07-27 21:56:16]

https://codereview.chromium.org/1253993004/diff/1/extensions/common/switches.cc
File extensions/common/switches.cc (right):

https://codereview.chromium.org/1253993004/diff/1/extensions/common/switches....
extensions/common/switches.cc:92: // This flag is enabled on Chromium for
testing purposes.
My reading is that the flag is available for use in Chromium builds and is only
enabled by default for Windows. Is this correct?

[sydli, 2015-07-27 22:06:18]

https://codereview.chromium.org/1253993004/diff/1/extensions/common/switches.cc
File extensions/common/switches.cc (right):

https://codereview.chromium.org/1253993004/diff/1/extensions/common/switches....
extensions/common/switches.cc:92: // This flag is enabled on Chromium for
testing purposes.
On 2015/07/27 21:56:16, robliao wrote:
> My reading is that the flag is available for use in Chromium builds and is
only
> enabled by default for Windows. Is this correct?

Yes, right now the prompt is enabled by default on Windows, and apparently will
be on Mac soon. Making the flag available on Chromium builds ensures tests that
auto-install extensions work on both.

[robliao, 2015-07-27 22:13:47]

https://codereview.chromium.org/1253993004/diff/1/extensions/common/switches.cc
File extensions/common/switches.cc (right):

https://codereview.chromium.org/1253993004/diff/1/extensions/common/switches....
extensions/common/switches.cc:92: // This flag is enabled on Chromium for
testing purposes.
On 2015/07/27 22:06:18, sydli wrote:
> On 2015/07/27 21:56:16, robliao wrote:
> > My reading is that the flag is available for use in Chromium builds and is
> only
> > enabled by default for Windows. Is this correct?
> 
> Yes, right now the prompt is enabled by default on Windows, and apparently
will
> be on Mac soon. Making the flag available on Chromium builds ensures tests
that
> auto-install extensions work on both.

Gotcha. Let's do s/enabled/available/ then.

[sydli, 2015-07-27 22:21:50]

https://codereview.chromium.org/1253993004/diff/1/extensions/common/switches.cc
File extensions/common/switches.cc (right):

https://codereview.chromium.org/1253993004/diff/1/extensions/common/switches....
extensions/common/switches.cc:92: // This flag is enabled on Chromium for
testing purposes.
On 2015/07/27 22:13:47, robliao wrote:
> On 2015/07/27 22:06:18, sydli wrote:
> > On 2015/07/27 21:56:16, robliao wrote:
> > > My reading is that the flag is available for use in Chromium builds and is
> > only
> > > enabled by default for Windows. Is this correct?
> > 
> > Yes, right now the prompt is enabled by default on Windows, and apparently
> will
> > be on Mac soon. Making the flag available on Chromium builds ensures tests
> that
> > auto-install extensions work on both.
> 
> Gotcha. Let's do s/enabled/available/ then.

Sounds good! Done.

[robliao, 2015-07-27 22:22:50]

lgtm

[asargent_no_longer_on_chrome, 2015-07-28 20:10:15]

lgtm

[sydli, 2015-07-28 21:39:14]

The CQ bit was checked by sydli@google.com

[sydli, 2015-07-28 21:39:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1253993004/#ps20001
(title: "Comment change in switches.cc")

[commit-bot: I haz the power, 2015-07-28 21:40:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1253993004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1253993004/20001

[commit-bot: I haz the power, 2015-07-28 22:52:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-28 22:52:54]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sydli, 2015-07-28 23:20:55]

The CQ bit was checked by sydli@google.com

[commit-bot: I haz the power, 2015-07-28 23:21:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1253993004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1253993004/20001

[commit-bot: I haz the power, 2015-07-28 23:53:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-28 23:54:06]

Patchset 2 (id:??) landed as
https://crrev.com/aa19ce5e62f69c5a8abc42e736d30b15aeee9794
Cr-Commit-Position: refs/heads/master@{#340812}