Move non-trivial constructors out-of-line.

Move non-trivial constructors out-of-line.

There is more than one way to skin this SkPathPriv.h cat.

These constructors are large enough that they probably shouldn't have
been inlined like this anyway.

BUG=skia:4126
Committed: https://skia.googlesource.com/skia/+/e88b1fb7a5fc25e6c6c194b7191678c0fdba5415

[mtklein_C, 2015-07-29 16:28:11]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-29 16:28:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1253963004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1253963004/1

[mtklein_C, 2015-07-29 16:28:24]

mtklein@chromium.org changed reviewers:
+ bungeman@google.com

[commit-bot: I haz the power, 2015-07-29 16:29:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-29 16:29:07]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[mtklein, 2015-07-29 16:29:35]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-29 16:29:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1253963004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1253963004/20001

[commit-bot: I haz the power, 2015-07-29 16:37:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-29 16:37:24]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2015-07-29 17:53:20]

On 2015/07/29 16:37:24, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

I know you just want this change to roll, but we're failing on SkOpBuilder? It
may be that SkRecords doesn't have anything to do with it? It seems that moving
everything other than SkPathPriv.h and then moving it later may help, or at
least narrow down what is happening.

[mtklein, 2015-07-29 17:58:48]

On 2015/07/29 17:53:20, bungeman1 wrote:
> On 2015/07/29 16:37:24, commit-bot: I haz the power wrote:
> > Dry run: This issue passed the CQ dry run.
> 
> I know you just want this change to roll, but we're failing on SkOpBuilder? It
> may be that SkRecords doesn't have anything to do with it? It seems that
moving
> everything other than SkPathPriv.h and then moving it later may help, or at
> least narrow down what is happening.

Yeah, let's do both.

[mtklein, 2015-07-29 19:34:49]

On 2015/07/29 17:58:48, mtklein wrote:
> On 2015/07/29 17:53:20, bungeman1 wrote:
> > On 2015/07/29 16:37:24, commit-bot: I haz the power wrote:
> > > Dry run: This issue passed the CQ dry run.
> > 
> > I know you just want this change to roll, but we're failing on SkOpBuilder?
It
> > may be that SkRecords doesn't have anything to do with it? It seems that
> moving
> > everything other than SkPathPriv.h and then moving it later may help, or at
> > least narrow down what is happening.
> 
> Yeah, let's do both.

So we're now at the point that we need to move SkPathPriv.h (to move
SkRecords.h, to move SkMiniRecorder.h).  Or we can break the chain here
(SkMiniRecorder.h really does need to see the sizeof() structs declared in
SkRecords.h).

[bungeman-skia, 2015-07-29 20:11:49]

lgtm

https://codereview.chromium.org/1253963004/diff/20001/src/core/SkRecords.h
File src/core/SkRecords.h (left):

https://codereview.chromium.org/1253963004/diff/20001/src/core/SkRecords.h#ol...
src/core/SkRecords.h:231: explicit PreCachedPath(const SkPath& path) :
SkPath(path) {
So this is the only one that *has* to move here, right?

[mtklein, 2015-07-29 20:13:08]

https://codereview.chromium.org/1253963004/diff/20001/src/core/SkRecords.h
File src/core/SkRecords.h (left):

https://codereview.chromium.org/1253963004/diff/20001/src/core/SkRecords.h#ol...
src/core/SkRecords.h:231: explicit PreCachedPath(const SkPath& path) :
SkPath(path) {
On 2015/07/29 20:11:49, bungeman1 wrote:
> So this is the only one that *has* to move here, right?

Correct.  The others just looked like good ideas.

(And if you'll notice, this is all a little silly, as use of SkPathPriv.h is
currently #ifdef'd out.)

[mtklein, 2015-07-29 20:13:12]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-07-29 20:13:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1253963004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1253963004/20001

[commit-bot: I haz the power, 2015-07-29 20:14:09]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e88b1fb7a5fc25e6c6c194b7191678c0fdba5415