Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/common_constants.gyp

Issue 1253953002: Componentize enhanced_bookmark_features.{h,cc}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove obsolete #include Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'chromium_code': 1, 7 'chromium_code': 1,
8 }, 8 },
9 9
10 'includes': [ 10 'includes': [
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 # GN version: //chrome/common:constants 70 # GN version: //chrome/common:constants
71 'target_name': 'common_constants', 71 'target_name': 'common_constants',
72 'type': 'static_library', 72 'type': 'static_library',
73 'include_dirs': [ 73 'include_dirs': [
74 '<(SHARED_INTERMEDIATE_DIR)', # Needed by chrome_paths.cc. 74 '<(SHARED_INTERMEDIATE_DIR)', # Needed by chrome_paths.cc.
75 ], 75 ],
76 'dependencies': [ 76 'dependencies': [
77 '../base/base.gyp:base', 77 '../base/base.gyp:base',
78 '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic _annotations', 78 '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic _annotations',
79 '../components/components.gyp:bookmarks_common', 79 '../components/components.gyp:bookmarks_common',
80 '../components/components.gyp:dom_distiller_core',
81 '../components/components.gyp:enhanced_bookmarks',
80 '../third_party/widevine/cdm/widevine_cdm.gyp:widevine_cdm_version_h', 82 '../third_party/widevine/cdm/widevine_cdm.gyp:widevine_cdm_version_h',
81 ], 83 ],
82 'target_conditions': [ 84 'target_conditions': [
83 ['OS=="ios"', { 85 ['OS=="ios"', {
84 # iOS needs chrome_paths_mac, which is excluded by filename rules; 86 # iOS needs chrome_paths_mac, which is excluded by filename rules;
85 # re-add it in target_conditionals so it's after that exclusion. 87 # re-add it in target_conditionals so it's after that exclusion.
86 'sources/': [ 88 'sources/': [
87 ['include', '^common/chrome_paths_mac\\.mm$'], 89 ['include', '^common/chrome_paths_mac\\.mm$'],
88 ], 90 ],
89 }], 91 }],
(...skipping 29 matching lines...) Expand all
119 'configurations': { 121 'configurations': {
120 'Common_Base': { 122 'Common_Base': {
121 'msvs_target_platform': 'x64', 123 'msvs_target_platform': 'x64',
122 }, 124 },
123 }, 125 },
124 }, 126 },
125 ], 127 ],
126 }], 128 }],
127 ], 129 ],
128 } 130 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698