Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Unified Diff: test/checker/checker_test.dart

Issue 1253903004: add special case for min/max, fixes #281 (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: small tweak for clarity Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/utils.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/checker/checker_test.dart
diff --git a/test/checker/checker_test.dart b/test/checker/checker_test.dart
index 2c14e06cf26fa0edf5428ecaff06961d6759e74d..593a4b6bb8f469c4a724a0843828bc9ea0ffdc83 100644
--- a/test/checker/checker_test.dart
+++ b/test/checker/checker_test.dart
@@ -2764,5 +2764,42 @@ void main() {
Iterable<int> baz5() sync* { yield* (/*info:InferredTypeAllocation*/new Iterable()); }
'''
}));
+
+ test(
+ 'dart:math min/max',
+ () => testChecker({
+ '/main.dart': '''
+ import 'dart:math';
+
+ void printInt(int x) => print(x);
+ void printDouble(double x) => print(x);
+
+ num myMax(num x, num y) => max(x, y);
+
+ main() {
+ // Okay if static types match.
+ printInt(max(1, 2));
+ printInt(min(1, 2));
+ printDouble(max(1.0, 2.0));
+ printDouble(min(1.0, 2.0));
+
+ // No help for user-defined functions from num->num->num.
+ printInt(/*warning:DownCastImplicit*/myMax(1, 2));
+ printInt(myMax(1, 2) as int);
+
+ // Mixing int and double means return type is num.
+ printInt(/*warning:DownCastImplicit*/max(1, 2.0));
+ printInt(/*warning:DownCastImplicit*/min(1, 2.0));
+ printDouble(/*warning:DownCastImplicit*/max(1, 2.0));
+ printDouble(/*warning:DownCastImplicit*/min(1, 2.0));
+
+ // Types other than int and double are not accepted.
+ printInt(
+ /*warning:DownCastImplicit*/min(
+ /*severe:StaticTypeError*/"hi",
+ /*severe:StaticTypeError*/"there"));
+ }
+ '''
+ }));
});
}
« no previous file with comments | « lib/src/utils.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698