Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1253903004: add special case for min/max, fixes #281 (Closed)

Created:
5 years, 4 months ago by Jennifer Messerly
Modified:
5 years, 4 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : small tweak for clarity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M lib/src/checker/resolver.dart View 1 1 chunk +23 lines, -0 lines 0 comments Download
M lib/src/dart_sdk.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M test/checker/checker_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
5 years, 4 months ago (2015-08-05 01:11:50 UTC) #3
Leaf
lgtm
5 years, 4 months ago (2015-08-05 17:58:27 UTC) #4
Jennifer Messerly
5 years, 4 months ago (2015-08-05 18:08:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
6402f7d4193f3e0ed887b7fda11c54c66871eb24 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698