Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1253873003: stray c++11 ud suffix fixes for tcmalloc files (Closed)

Created:
5 years, 5 months ago by Mostyn Bramley-Moore
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

stray c++11 ud suffix fixes for tcmalloc files Followup to https://codereview.chromium.org/21157004 - here are a few more warnings that we can silence. BUG=263960 Committed: https://crrev.com/5e17dd65b9bee51dc12bba6d3c5df99e14bf3f85 Cr-Commit-Position: refs/heads/master@{#340357}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add another missing space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/tcmalloc/chromium/src/base/sysinfo.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/tcmalloc/chromium/src/debugallocation.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
Mostyn Bramley-Moore
@Nico: this fixes a few c++11 warnings that were left behind by https://codereview.chromium.org/21157004
5 years, 5 months ago (2015-07-24 09:10:33 UTC) #2
Nico
lgtm
5 years, 5 months ago (2015-07-24 18:24:51 UTC) #3
Nico
(you build on freebsd?)
5 years, 5 months ago (2015-07-24 18:25:01 UTC) #4
Mostyn Bramley-Moore
On 2015/07/24 18:25:01, Nico (hiding) wrote: > (you build on freebsd?) No- just linux, mostly ...
5 years, 5 months ago (2015-07-24 20:57:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253873003/1
5 years, 5 months ago (2015-07-24 20:58:32 UTC) #7
Nico
https://codereview.chromium.org/1253873003/diff/1/third_party/tcmalloc/chromium/src/base/sysinfo.cc File third_party/tcmalloc/chromium/src/base/sysinfo.cc (right): https://codereview.chromium.org/1253873003/diff/1/third_party/tcmalloc/chromium/src/base/sysinfo.cc#newcode897 third_party/tcmalloc/chromium/src/base/sysinfo.cc:897: #elif defined(__FreeBSD__) this is a freebsd block though?
5 years, 5 months ago (2015-07-24 20:59:16 UTC) #8
Mostyn Bramley-Moore
https://codereview.chromium.org/1253873003/diff/1/third_party/tcmalloc/chromium/src/base/sysinfo.cc File third_party/tcmalloc/chromium/src/base/sysinfo.cc (right): https://codereview.chromium.org/1253873003/diff/1/third_party/tcmalloc/chromium/src/base/sysinfo.cc#newcode897 third_party/tcmalloc/chromium/src/base/sysinfo.cc:897: #elif defined(__FreeBSD__) On 2015/07/24 20:59:16, Nico (hiding) wrote: > ...
5 years, 5 months ago (2015-07-24 21:16:50 UTC) #10
Nico
no, it's fine as is (i already lgtm'd and all), i was just curious
5 years, 5 months ago (2015-07-24 21:23:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253873003/20001
5 years, 5 months ago (2015-07-24 21:48:02 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-24 22:35:45 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 22:36:34 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5e17dd65b9bee51dc12bba6d3c5df99e14bf3f85
Cr-Commit-Position: refs/heads/master@{#340357}

Powered by Google App Engine
This is Rietveld 408576698