Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1253823002: Proof-reading comments in mojo/runner. (Closed)

Created:
5 years, 5 months ago by qyearsley
Modified:
5 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Proof-reading comments in mojo/runner. Committed: https://crrev.com/40f6ff642a53681e2367c2d7dbb2fc5af1701c97 Cr-Commit-Position: refs/heads/master@{#340373}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M mojo/runner/android/apk/src/org/chromium/mojo/shell/AndroidHandler.java View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/native_application_support.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/shell_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/switches.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/runner/url_resolver.h View 3 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
qyearsley
I was just reading through mojo/runner/url_resolver.{h,cc} and some other files here -- this CL would ...
5 years, 5 months ago (2015-07-23 23:53:21 UTC) #2
sky
LGTM
5 years, 5 months ago (2015-07-23 23:56:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253823002/20001
5 years, 5 months ago (2015-07-24 00:14:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/99381) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-24 00:20:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253823002/20001
5 years, 5 months ago (2015-07-24 23:13:46 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-24 23:21:45 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 23:22:12 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/40f6ff642a53681e2367c2d7dbb2fc5af1701c97
Cr-Commit-Position: refs/heads/master@{#340373}

Powered by Google App Engine
This is Rietveld 408576698