sync: Handle POLL jobs in separate a code path

sync/engine/sync_scheduler_whitebox_unittest.cc

Index: sync/engine/sync_scheduler_whitebox_unittest.cc
diff --git a/sync/engine/sync_scheduler_whitebox_unittest.cc b/sync/engine/sync_scheduler_whitebox_unittest.cc
index 01adb85ee79235a2e179980e6fef2fdf583cd63f..8c6ddbf41afb9d93ee577106dd4c316cfb23e84b 100644
--- a/sync/engine/sync_scheduler_whitebox_unittest.cc
+++ b/sync/engine/sync_scheduler_whitebox_unittest.cc
@@ -174,25 +174,6 @@ TEST_F(SyncSchedulerWhiteboxTest, ContinueNudge) {
   EXPECT_EQ(decision, SyncSchedulerImpl::CONTINUE);
 }
 
-TEST_F(SyncSchedulerWhiteboxTest, DropPoll) {

[rlarocque, 2013/03/18 22:02:18]

I think it's safe to drop these tests, since the logic should be well covered by
the non-whitebox SyncSchedulerTests like SyncSchedulerTest.BackoffDropsJobs,
SyncSchedulerTest.ConfigureMode.

If you're really concerned about this, I could be convinced to factor the poll
decision-making into a separate function for test purposes.

-  InitializeSyncerOnNormalMode();
-  SetMode(SyncScheduler::CONFIGURATION_MODE);
-
-  SyncSchedulerImpl::JobProcessDecision decision = CreateAndDecideJob(
-      SyncSessionJob::POLL);
-
-  EXPECT_EQ(decision, SyncSchedulerImpl::DROP);
-}
-
-TEST_F(SyncSchedulerWhiteboxTest, ContinuePoll) {
-  InitializeSyncerOnNormalMode();
-
-  SyncSchedulerImpl::JobProcessDecision decision = CreateAndDecideJob(
-      SyncSessionJob::POLL);
-
-  EXPECT_EQ(decision, SyncSchedulerImpl::CONTINUE);
-}
-
 TEST_F(SyncSchedulerWhiteboxTest, ContinueConfiguration) {
   InitializeSyncerOnNormalMode();
   SetMode(SyncScheduler::CONFIGURATION_MODE);