Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 12538012: Mac: "Import bookmarks..." right click shouldn't bring up context menu. (Closed)

Created:
7 years, 9 months ago by Alexei Svitkine (slow)
Modified:
7 years, 9 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, tfarina, sail+watch_chromium.org
Visibility:
Public.

Description

Mac: "Import bookmarks..." right click shouldn't bring up context menu. XIB changes: Changed class of the import button item back to NSButton and unhooked the barView_ outlet. BUG=214212 TEST=Right click on "Import bookmarks..." links in an empty BMB. No context menu should be shown. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188887

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -38 lines) Patch
M chrome/app/nibs/BookmarkBar.xib View 4 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.h View 3 chunks +2 lines, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm View 1 3 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alexei Svitkine (slow)
7 years, 9 months ago (2013-03-18 19:18:41 UTC) #1
Robert Sesek
LGTM https://codereview.chromium.org/12538012/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm (right): https://codereview.chromium.org/12538012/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm#newcode105 chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm:105: -(NSButton*)importBookmarksButton { nit: space before ( and on ...
7 years, 9 months ago (2013-03-18 19:20:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/12538012/4001
7 years, 9 months ago (2013-03-18 19:35:23 UTC) #3
Alexei Svitkine (slow)
https://chromiumcodereview.appspot.com/12538012/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm (right): https://chromiumcodereview.appspot.com/12538012/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm#newcode105 chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm:105: -(NSButton*)importBookmarksButton { On 2013/03/18 19:20:05, rsesek wrote: > nit: ...
7 years, 9 months ago (2013-03-18 19:41:27 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-19 00:40:21 UTC) #5
Message was sent while issue was closed.
Change committed as 188887

Powered by Google App Engine
This is Rietveld 408576698