Public Sessions: fetch device robot api token during enterprise enrollment.

chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc

Index: chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
diff --git a/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc b/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
index 7c5692d26925fbf182abb8094c7de006275cc0d4..c4f7205ad90883e8d90c9b40525f2ff0358b6a70 100644
--- a/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
+++ b/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
@@ -7,10 +7,14 @@
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.h"
 #include "chrome/browser/chromeos/policy/proto/chrome_device_policy.pb.h"
+#include "chrome/browser/chromeos/settings/device_oauth2_token_service.h"
+#include "chrome/browser/chromeos/settings/device_oauth2_token_service_factory.h"
 #include "chrome/browser/policy/cloud/cloud_policy_constants.h"
 #include "chrome/browser/policy/cloud/proto/device_management_backend.pb.h"
+#include "google_apis/gaia/gaia_urls.h"
 
 namespace em = enterprise_management;
 
@@ -129,18 +133,37 @@ void EnrollmentHandlerChromeOS::OnRegistrationStateChanged(
 void EnrollmentHandlerChromeOS::OnClientError(CloudPolicyClient* client) {
   DCHECK_EQ(client_.get(), client);
 
-  if (enrollment_step_ < STEP_POLICY_FETCH)
+  if (enrollment_step_ == STEP_ROBOT_AUTH_FETCH) {
+    LOG(WARNING) << "API authentication code fetch failed: "
+                 << client_->status();
+    // Robot auth tokens are currently optional.  Skip fetching the refresh
+    // token and jump directly to the lock device step.

[Mattias Nissler (ping if slow), 2013/04/24 13:43:13]

same here.

[David Roche, 2013/04/24 15:34:21]

I can't puzzle out what "same here" means in this context.  Your other context
are about google-isms and method naming.

[Mattias Nissler (ping if slow), 2013/04/24 17:58:52]

I'm not sure either? Maybe this is an artifact of another comment I removed.
Please disregard.

+    robot_refresh_token_.clear();
+    WriteInstallAttributesAndLockDevice();
+  } else if (enrollment_step_ < STEP_POLICY_FETCH) {
     ReportResult(EnrollmentStatus::ForRegistrationError(client_->status()));
-  else
+  } else {
     ReportResult(EnrollmentStatus::ForFetchError(client_->status()));
+  }
 }
 
 void EnrollmentHandlerChromeOS::OnStoreLoaded(CloudPolicyStore* store) {
   DCHECK_EQ(store_, store);
 
   if (enrollment_step_ == STEP_LOADING_STORE) {
+    // If the |store_| wasn't initialized when StartEnrollment() was
+    // called, then AttemptRegistration() bails silently.  This gets
+    // registration rolling again after the store finishes loading.
     AttemptRegistration();
   } else if (enrollment_step_ == STEP_STORE_POLICY) {
+    // Store the robot API auth refresh token.
+    // Currently optional, until DMServer support is fully in production.
+    chromeos::DeviceOAuth2TokenService* token_service =
+        chromeos::DeviceOAuth2TokenServiceFactory::Get();
+    if (token_service && !robot_refresh_token_.empty()) {
+      token_service->SetAndSaveRefreshToken(robot_refresh_token_);
+
+    }
     ReportResult(EnrollmentStatus::ForStatus(EnrollmentStatus::STATUS_SUCCESS));
   }
 }
@@ -165,14 +188,81 @@ void EnrollmentHandlerChromeOS::PolicyValidated(
   CHECK_EQ(STEP_VALIDATION, enrollment_step_);
   if (validator->success()) {
     policy_ = validator->policy().Pass();
-    enrollment_step_ = STEP_LOCK_DEVICE;
-    WriteInstallAttributes(validator->policy_data()->username(), device_mode_,
-                           validator->policy_data()->device_id());
+    username_ = validator->policy_data()->username();
+    device_id_ = validator->policy_data()->device_id();
+
+    enrollment_step_ = STEP_ROBOT_AUTH_FETCH;
+    client_->FetchRobotAuthCodes(auth_token_);
   } else {
     ReportResult(EnrollmentStatus::ForValidationError(validator->status()));
   }
 }
 
+void EnrollmentHandlerChromeOS::OnRobotAuthCodesFetched(
+    CloudPolicyClient* client) {
+  DCHECK_EQ(client_.get(), client);
+  CHECK_EQ(STEP_ROBOT_AUTH_FETCH, enrollment_step_);
+
+  enrollment_step_ = STEP_ROBOT_AUTH_REFRESH;
+
+  gaia::OAuthClientInfo client_info;
+  client_info.client_id = GaiaUrls::GetInstance()->oauth2_chrome_client_id();
+  client_info.client_secret =
+      GaiaUrls::GetInstance()->oauth2_chrome_client_secret();
+
+  // Use the system request context to avoid sending user cookies.
+  gaia_oauth_client_.reset(new gaia::GaiaOAuthClient(
+      gaia::kGaiaOAuth2Url,
+      g_browser_process->system_request_context()));
+  gaia_oauth_client_->GetTokensFromAuthCode(client_info,
+                                            client->robot_api_auth_code(),
+                                            0 /* max_retries */,
+                                            this);
+}
+
+// GaiaOAuthClient::Delegate callback for OAuth2 refresh token fetched.
+void EnrollmentHandlerChromeOS::OnGetTokensResponse(
+    const std::string& refresh_token,
+    const std::string& access_token,
+    int expires_in_seconds) {
+  CHECK_EQ(STEP_ROBOT_AUTH_REFRESH, enrollment_step_);
+
+  robot_refresh_token_ = refresh_token;
+
+  WriteInstallAttributesAndLockDevice();
+}
+
+void EnrollmentHandlerChromeOS::WriteInstallAttributesAndLockDevice() {
+  enrollment_step_ = STEP_LOCK_DEVICE,
+  WriteInstallAttributes(username_, device_mode_, device_id_);
+}
+
+// GaiaOAuthClient::Delegate
+void EnrollmentHandlerChromeOS::OnRefreshTokenResponse(
+    const std::string& access_token,
+    int expires_in_seconds) {
+  // We never use the code that should trigger this callback.
+  LOG(FATAL) << "Unexpected callback invoked";
+}
+
+// GaiaOAuthClient::Delegate OAuth2 error when fetching refresh token request.
+void EnrollmentHandlerChromeOS::OnOAuthError() {
+  // TODO(davidroche): return STATUS_ROBOT_REFRESH_FETCH_FAILED when fetching
+  // tokens is required for enrollment.
+  CHECK_EQ(STEP_ROBOT_AUTH_REFRESH, enrollment_step_);
+  WriteInstallAttributesAndLockDevice();
+}
+
+// GaiaOAuthClient::Delegate network error when fetching refresh token.
+void EnrollmentHandlerChromeOS::OnNetworkError(int response_code) {
+  LOG(ERROR) << "Network error while fetching API refresh token: "
+             << response_code;
+  // TODO(davidroche): return STATUS_ROBOT_REFRESH_FETCH_FAILED when fetching
+  // tokens is required for enrollment.
+  CHECK_EQ(STEP_ROBOT_AUTH_REFRESH, enrollment_step_);
+  WriteInstallAttributesAndLockDevice();
+}
+
 void EnrollmentHandlerChromeOS::WriteInstallAttributes(
     const std::string& user,
     DeviceMode device_mode,