Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1253793002: Fix `mojo_run` to not require inferred adb path when running on Linux. (Closed)

Created:
5 years, 5 months ago by ppi
Modified:
5 years, 5 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix `mojo_run` to not require inferred adb path when running on Linux. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/aabd39e6677d1d0221f7890799596e44e0a837fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/devtools/common/mojo_run View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ppi
Hi Ben, ptal.
5 years, 5 months ago (2015-07-23 22:46:47 UTC) #1
qsr
lgtm
5 years, 5 months ago (2015-07-23 22:47:08 UTC) #2
ppi
5 years, 5 months ago (2015-07-23 22:51:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aabd39e6677d1d0221f7890799596e44e0a837fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698