Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: remoting/test/app_remoting_connection_helper.h

Issue 1253613002: Updated latency fixture and refactored connection helper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: "Changed cstdint to stdint.h to compile on mac" Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/test/app_remoting_connection_helper.h
diff --git a/remoting/test/app_remoting_connection_helper.h b/remoting/test/app_remoting_connection_helper.h
index 6978747688b9d603c9452be8304f6523ab14d818..04269a31c8a27a681a9f92c8182b3976c6e118a0 100644
--- a/remoting/test/app_remoting_connection_helper.h
+++ b/remoting/test/app_remoting_connection_helper.h
@@ -25,10 +25,6 @@ namespace test {
struct RemoteApplicationDetails;
class TestChromotingClient;
-// Allows for custom handling of ExtensionMessage messages.
-typedef base::Callback<void(const protocol::ExtensionMessage& message)>
- HostMessageReceivedCallback;
-
// Creates a connection to a remote host which is available for tests to use.
// A TestChromotingClient is required from caller.
class AppRemotingConnectionHelper
@@ -45,16 +41,14 @@ class AppRemotingConnectionHelper
// NOTE: Initialize() must be called before calling this method.
bool StartConnection();
- // Stubs used to send messages to the remote host. Caller should not release
- // the objects.
+ // Stubs used to send messages to the remote host.
protocol::ClipboardStub* clipboard_forwarder();
protocol::HostStub* host_stub();
protocol::InputStub* input_stub();
- // Setter for |host_message_received_callback_|.
- void SetHostMessageReceivedCallback(
- HostMessageReceivedCallback host_message_received_callback);
+ TestChromotingClient* test_chromoting_client() { return client_.get(); }
+ // Returns true if connection is ready for tests.
bool ConnectionIsReadyForTest() { return connection_is_ready_for_tests_; }
private:
@@ -74,10 +68,6 @@ class AppRemotingConnectionHelper
// Contains the details for the application being tested.
const RemoteApplicationDetails& application_details_;
- // Called when an ExtensionMessage is received from the host. Used to
- // override default message handling.
- HostMessageReceivedCallback host_message_received_callback_;
-
// Indicates whether the remote connection is ready to be used for testing.
// True when a chromoting connection to the remote host has been established
// and the main application window is visible.
« no previous file with comments | « remoting/test/app_remoting_connected_client_fixture.cc ('k') | remoting/test/app_remoting_connection_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698