Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: remoting/test/app_remoting_connection_helper.h

Issue 1253613002: Updated latency fixture and refactored connection helper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: "Updated naming for accessor of test_chromoting_client_" Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/test/app_remoting_connection_helper.h
diff --git a/remoting/test/app_remoting_connection_helper.h b/remoting/test/app_remoting_connection_helper.h
index 6978747688b9d603c9452be8304f6523ab14d818..5085f97723f9543a6af0fd3452c9b1970e19b6d4 100644
--- a/remoting/test/app_remoting_connection_helper.h
+++ b/remoting/test/app_remoting_connection_helper.h
@@ -25,10 +25,6 @@ namespace test {
struct RemoteApplicationDetails;
class TestChromotingClient;
-// Allows for custom handling of ExtensionMessage messages.
-typedef base::Callback<void(const protocol::ExtensionMessage& message)>
- HostMessageReceivedCallback;
-
// Creates a connection to a remote host which is available for tests to use.
// A TestChromotingClient is required from caller.
class AppRemotingConnectionHelper
@@ -51,10 +47,11 @@ class AppRemotingConnectionHelper
protocol::HostStub* host_stub();
protocol::InputStub* input_stub();
- // Setter for |host_message_received_callback_|.
- void SetHostMessageReceivedCallback(
- HostMessageReceivedCallback host_message_received_callback);
+ // Returns the test chromoting client.
Sergey Ulanov 2015/07/27 18:40:24 nit: this comment doesn't really add anything. Rem
liaoyuke 2015/07/27 19:02:57 Done.
+ // NOTE: Caller should not release the object.
Sergey Ulanov 2015/07/27 18:40:24 s/release/delete/ or just remove the comment. This
liaoyuke 2015/07/27 19:02:57 Done.
+ TestChromotingClient* test_chromoting_client() { return client_.get(); }
+ // Returns true if connection is ready for tests.
bool ConnectionIsReadyForTest() { return connection_is_ready_for_tests_; }
private:
@@ -74,10 +71,6 @@ class AppRemotingConnectionHelper
// Contains the details for the application being tested.
const RemoteApplicationDetails& application_details_;
- // Called when an ExtensionMessage is received from the host. Used to
- // override default message handling.
- HostMessageReceivedCallback host_message_received_callback_;
-
// Indicates whether the remote connection is ready to be used for testing.
// True when a chromoting connection to the remote host has been established
// and the main application window is visible.

Powered by Google App Engine
This is Rietveld 408576698