Updated latency fixture and refactored connection helper

remoting/test/app_remoting_latency_test_fixture.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/test/app_remoting_latency_test_fixture.h"
 
 #include "base/logging.h"
 #include "base/run_loop.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/timer/timer.h"
@@ skipping 18 matching lines @@
 
 void AppRemotingLatencyTestFixture::SetUp() {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   scoped_ptr<TestVideoRenderer> test_video_renderer(new TestVideoRenderer());
   test_video_renderer_ = test_video_renderer->GetWeakPtr();
 
   scoped_ptr<TestChromotingClient> test_chromoting_client(
       new TestChromotingClient(test_video_renderer.Pass()));
 
+  test_chromoting_client_ = test_chromoting_client->GetWeakPtr();
+
+  test_chromoting_client_->AddRemoteConnectionObserver(this);
+
   connection_helper_.reset(
       new AppRemotingConnectionHelper(GetApplicationDetails()));
   connection_helper_->Initialize(test_chromoting_client.Pass());
 
   if (!connection_helper_->StartConnection()) {
     LOG(ERROR) << "Remote host connection could not be established.";
     FAIL();
   }
+
+  if (!CreateNewDocument()) {
+    LOG(ERROR) << "New document could not be created.";
+    FAIL();

[joedow, 2015/07/23 20:26:56]

Have you run this through the try-bots yet?  I seem to recall Tony having a
problem on one build flavor where having code after FAIL() (on line 49 in your
case) would cause a build failure.  You should push this to the try-bots when
you've updated the code just to make sure it builds OK for all flavors.

[liaoyuke, 2015/07/24 02:07:28]

Yeah, I'll run try-bots on my next patch.

+  }
 }
 
 void AppRemotingLatencyTestFixture::TearDown() {
   // Only reset application state when remote host connection is established.
   if (connection_helper_->ConnectionIsReadyForTest()) {
     ResetApplicationState();
   }
 
+  test_chromoting_client_->RemoveRemoteConnectionObserver(this);
   connection_helper_.reset();
 }
 
 WaitForImagePatternMatchCallback
 AppRemotingLatencyTestFixture::SetExpectedImagePattern(
     const webrtc::DesktopRect& expected_rect,
     uint32_t expected_color) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   scoped_ptr<base::RunLoop> run_loop(new base::RunLoop());
@@ skipping 19 matching lines @@
   run_loop->Run();
 
   // Image pattern is matched if we stopped because of the reply not the timer.
   bool image_pattern_is_matched = (timer_->IsRunning());
   timer_->Stop();
   run_loop.reset();
 
   return image_pattern_is_matched;
 }
 
+void AppRemotingLatencyTestFixture::HostMessageReceived(
+    const protocol::ExtensionMessage& message) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+
+  if (!host_message_received_callback_.is_null()) {
+    host_message_received_callback_.Run(message);
+  }
+}
+
 void AppRemotingLatencyTestFixture::PressKey(uint32_t usb_keycode,
                                              bool pressed) {
   remoting::protocol::KeyEvent event;
   event.set_usb_keycode(usb_keycode);
   event.set_pressed(pressed);
   connection_helper_->input_stub()->InjectKeyEvent(event);
 }
 
 void AppRemotingLatencyTestFixture::PressAndReleaseKey(uint32_t usb_keycode) {
   PressKey(usb_keycode, true);
@@ skipping 41 matching lines @@
 
   run_loop_.reset(new base::RunLoop());
   base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
       FROM_HERE, run_loop_->QuitClosure(), base::TimeDelta::FromSeconds(2));
   run_loop_->Run();
   run_loop_.reset();
 }
 
 }  // namespace test
 }  // namespace remoting