Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: src/device/xps/SkXPSDevice.cpp

Issue 12536008: Enable init'ed but unused var warning on windows for closer parity with mac/linux warnings. (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/device/xps/SkXPSDevice.cpp
===================================================================
--- src/device/xps/SkXPSDevice.cpp (revision 8271)
+++ src/device/xps/SkXPSDevice.cpp (working copy)
@@ -950,7 +950,6 @@
SkASSERT(1 == info.fColorCount);
SkColor color;
info.fColors = &color;
- SkShader::GradientType gradientType = shader->asAGradient(&info);
reed1 2013/03/21 13:14:24 Why did we eliminate this line, given that we insp
bsalomon 2013/03/21 13:45:29 I misunderstood the code and thought these calls w
SkAlpha alpha = skPaint.getAlpha();
HR(this->createXpsSolidColorBrush(color, alpha, brush));
return S_OK;
@@ -966,7 +965,6 @@
SkAutoTArray<SkScalar> colorOffsets(info.fColorCount);
info.fColors = colors.get();
info.fColorOffsets = colorOffsets.get();
- shader->asAGradient(&info);
reed1 2013/03/21 13:14:24 Why did we eliminate this call, given that we insp
if (1 == info.fColorCount) {
SkColor color = info.fColors[0];

Powered by Google App Engine
This is Rietveld 408576698