Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1253573008: Only update symbols on current thread when breaking or stepping in GDB. (Closed)

Created:
5 years, 5 months ago by etiennej
Modified:
5 years, 5 months ago
Reviewers:
kulakowski, ppi
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Only update symbols on current thread when breaking or stepping in GDB. R=ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c02a28868825edfa57ab77947b8cb15e741c5598

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix wording #

Total comments: 9

Patch Set 3 : ppi comments & fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -28 lines) Patch
M mojo/devtools/common/README.md View 1 2 chunks +19 lines, -2 lines 0 comments Download
M mojo/devtools/common/android_gdb/session.py View 1 2 3 chunks +70 lines, -26 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
etiennej
5 years, 5 months ago (2015-07-23 22:03:18 UTC) #2
kulakowski
https://codereview.chromium.org/1253573008/diff/1/mojo/devtools/common/README.md File mojo/devtools/common/README.md (right): https://codereview.chromium.org/1253573008/diff/1/mojo/devtools/common/README.md#newcode51 mojo/devtools/common/README.md:51: from loaded Mojo applications. Please note that this initial ...
5 years, 5 months ago (2015-07-23 22:07:20 UTC) #4
etiennej
https://codereview.chromium.org/1253573008/diff/1/mojo/devtools/common/README.md File mojo/devtools/common/README.md (right): https://codereview.chromium.org/1253573008/diff/1/mojo/devtools/common/README.md#newcode51 mojo/devtools/common/README.md:51: from loaded Mojo applications. Please note that this initial ...
5 years, 5 months ago (2015-07-23 22:29:23 UTC) #5
ppi
Thanks for extensive documentation! https://codereview.chromium.org/1253573008/diff/20001/mojo/devtools/common/android_gdb/session.py File mojo/devtools/common/android_gdb/session.py (right): https://codereview.chromium.org/1253573008/diff/20001/mojo/devtools/common/android_gdb/session.py#newcode193 mojo/devtools/common/android_gdb/session.py:193: def _find_mappings_current_thread(self, mapped_files): this method ...
5 years, 5 months ago (2015-07-23 23:08:32 UTC) #6
ppi
https://codereview.chromium.org/1253573008/diff/20001/mojo/devtools/common/android_gdb/session.py File mojo/devtools/common/android_gdb/session.py (right): https://codereview.chromium.org/1253573008/diff/20001/mojo/devtools/common/android_gdb/session.py#newcode281 mojo/devtools/common/android_gdb/session.py:281: self.update_symbols(False) I meant (current_thread_only=False).
5 years, 5 months ago (2015-07-23 23:09:32 UTC) #7
etiennej
https://codereview.chromium.org/1253573008/diff/20001/mojo/devtools/common/android_gdb/session.py File mojo/devtools/common/android_gdb/session.py (right): https://codereview.chromium.org/1253573008/diff/20001/mojo/devtools/common/android_gdb/session.py#newcode193 mojo/devtools/common/android_gdb/session.py:193: def _find_mappings_current_thread(self, mapped_files): On 2015/07/23 23:08:31, ppi wrote: > ...
5 years, 5 months ago (2015-07-23 23:21:03 UTC) #8
ppi
lgtm
5 years, 5 months ago (2015-07-23 23:26:09 UTC) #9
etiennej
5 years, 5 months ago (2015-07-23 23:28:14 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
c02a28868825edfa57ab77947b8cb15e741c5598 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698