Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1253573004: X87: Eliminate redundant descriptor ElementTransitionAndStoreDescriptor. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Eliminate redundant descriptor ElementTransitionAndStoreDescriptor. port 26ffee2c718308bb85be072ed32479e4aa8e7e6b (r29789). original commit message: It's just the same as StoreTransitionDescriptor. BUG= Committed: https://crrev.com/1dfcf3506cb73fe76c2f10370561943d77fea6b0 Cr-Commit-Position: refs/heads/master@{#29831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M src/ic/x87/access-compiler-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/x87/ic-compiler-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-07-24 01:58:32 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-24 02:12:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253573004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253573004/1
5 years, 5 months ago (2015-07-24 03:54:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 06:22:15 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 06:22:47 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1dfcf3506cb73fe76c2f10370561943d77fea6b0
Cr-Commit-Position: refs/heads/master@{#29831}

Powered by Google App Engine
This is Rietveld 408576698