Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1253543002: Call ::SetUp() and ::TearDown() of base class (Closed)

Created:
5 years, 5 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call ::SetUp() and ::TearDown() of base class Test is not executed if InProcessBrowserTest::SetUp() was not called. BUG=511463, 406227 Committed: https://crrev.com/7b90c1f386a2ba38f50f0b3ba3dbc00b5d5de8b5 Cr-Commit-Position: refs/heads/master@{#340021}

Patch Set 1 #

Patch Set 2 : Wed Jul 22 14:19:28 PDT 2015 #

Patch Set 3 : Wed Jul 22 17:27:20 PDT 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M chrome/browser/service_process/service_process_control_browsertest.cc View 1 2 4 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253543002/20001
5 years, 5 months ago (2015-07-22 21:21:49 UTC) #3
pval...(no longer on Chromium)
lgtm Cool! I'm happy this "just works" :-)
5 years, 5 months ago (2015-07-22 22:39:02 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/90292)
5 years, 5 months ago (2015-07-22 22:50:15 UTC) #6
Vitaly Buka (NO REVIEWS)
Almost "just works".
5 years, 5 months ago (2015-07-23 00:28:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253543002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253543002/40001
5 years, 5 months ago (2015-07-23 00:29:14 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-23 01:36:11 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 01:37:12 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7b90c1f386a2ba38f50f0b3ba3dbc00b5d5de8b5
Cr-Commit-Position: refs/heads/master@{#340021}

Powered by Google App Engine
This is Rietveld 408576698