Issue 125353006: Test Keeping NaCl plugins used in app background pages alive when active.

Issue 125353006: Test Keeping NaCl plugins used in app background pages alive when active. (Closed)

Created:
6 years, 11 months ago by scheib

Modified:
6 years, 11 months ago

Reviewers:
yzshen1

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Test Keeping NaCl plugins used in app background pages alive when active. (Re-landing with fixes from https://codereview.chromium.org/112663007/ ) Activity in Native Client plugins results in IPC messages sent to the BrowserPpapiHostImpl and routed to call extensions::ProcessManager::KeepaliveImpulse. Testing patch, builds on implementation: https://codereview.chromium.org/61063003/ Design doc: https://docs.google.com/a/chromium.org/document/d/1mI0lS1rfAf-BAGLmWAEcWy37Xq9dOvgfMx8OqeUMXts/edit# BUG=298339 No change to mseaborn owned file since last LGTM: R=yzshen@chromium.org TBR=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243326

Patch Set 1 : Previous patch, which failed on XP bots #

Patch Set 2 : Disable idle tests on windows #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+327 lines, -3 lines)			Patch
M	chrome/browser/extensions/DEPS	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/app_background_page_apitest.cc	View	1	5 chunks	+134 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	components/nacl/browser/nacl_process_host.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	extensions/browser/process_manager.h	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	extensions/browser/process_manager.cc	View		3 chunks	+17 lines, -1 line	0 comments	Download
M	ppapi/proxy/plugin_main_nacl.cc	View		5 chunks	+17 lines, -0 lines	0 comments	Download
M	ppapi/shared_impl/ppapi_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/shared_impl/ppapi_switches.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	ppapi/tests/extensions/background_keepalive/background.cc	View		1 chunk	+63 lines, -0 lines	0 comments	Download
A	ppapi/tests/extensions/background_keepalive/background.js	View		1 chunk	+41 lines, -0 lines	0 comments	Download
A	ppapi/tests/extensions/background_keepalive/manifest.json	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	ppapi/tests/extensions/extensions.gyp	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheib

Committed patchset #2 manually as r243326 (presubmit successful).

6 years, 11 months ago (2014-01-07 17:47:02 UTC) #3

Noam Samuel

6 years, 11 months ago (2014-01-08 18:50:12 UTC) #4

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/128433005/ by noamsml@chromium.org.

The reason for reverting is: http://crbug.com/332440.

Expand Messages | Collapse Messages