Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 125353002: Don't include _unittest.py files in `grit_info --inputs` output. (Closed)

Created:
6 years, 11 months ago by Nico
Modified:
6 years, 11 months ago
Reviewers:
Jói
CC:
grit-developer_googlegroups.com
Visibility:
Public.

Description

Don't include _unittest.py files in `grit_info --inputs` output. If only a test changes, it shouldn't affect the files created by grit, so this is useless output. Reduces the size of chrome's ninja files by about 120kB / 1%. r144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M grit_info.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
6 years, 11 months ago (2014-01-06 20:13:43 UTC) #1
Nico
Committed as r144 (looks like joi's lgtm didn't make it through to rietveld, but he ...
6 years, 11 months ago (2014-01-08 00:50:00 UTC) #2
Jói
6 years, 11 months ago (2014-01-08 09:07:55 UTC) #3
Message was sent while issue was closed.
On 2014/01/08 00:50:00, Nico wrote:
> Committed as r144 (looks like joi's lgtm didn't make it through to rietveld,
but
> he lg'd over email)

LGTM for the record.

Powered by Google App Engine
This is Rietveld 408576698