Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1253513003: Name of primitive processor will now be printed in generated shader code (Closed)

Created:
5 years, 5 months ago by wangyix
Modified:
5 years, 5 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Name of primitive processor will now be printed in generated shader code BUG=skia: Committed: https://skia.googlesource.com/skia/+/150714fb16f8afd8a5fc91772ceed77728107473

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
wangyix
5 years, 5 months ago (2015-07-23 14:29:43 UTC) #2
joshualitt
On 2015/07/23 14:29:43, wangyix wrote: did this actually work?
5 years, 5 months ago (2015-07-23 14:36:41 UTC) #3
wangyix
On 2015/07/23 14:36:41, joshualitt wrote: > On 2015/07/23 14:29:43, wangyix wrote: > > did this ...
5 years, 5 months ago (2015-07-23 14:39:46 UTC) #4
joshualitt
On 2015/07/23 14:39:46, wangyix wrote: > On 2015/07/23 14:36:41, joshualitt wrote: > > On 2015/07/23 ...
5 years, 5 months ago (2015-07-23 14:41:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253513003/1
5 years, 5 months ago (2015-07-23 14:49:51 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 15:02:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/150714fb16f8afd8a5fc91772ceed77728107473

Powered by Google App Engine
This is Rietveld 408576698