Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1253473002: Add drawImage{Rect,} support to SkDebugCanvas (Closed)

Created:
5 years, 5 months ago by f(malita)
Modified:
5 years, 5 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org, reed1
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : win warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -2 lines) Patch
M src/utils/debugger/SkDebugCanvas.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.h View 2 chunks +32 lines, -0 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.cpp View 1 2 chunks +60 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
f(malita)
5 years, 5 months ago (2015-07-22 16:52:09 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253473002/1
5 years, 5 months ago (2015-07-22 16:52:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253473002/20001
5 years, 5 months ago (2015-07-22 16:55:52 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 5 months ago (2015-07-22 16:55:53 UTC) #6
robertphillips
lgtm
5 years, 5 months ago (2015-07-22 17:21:11 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 17:23:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/651c920d2f8671756968366c7ed9b455fc1a096c

Powered by Google App Engine
This is Rietveld 408576698