Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: ui/gl/gl_gl_api_implementation.h

Issue 1253433002: Fix GL extension filtering so that extension bits are set correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove RealGLApi::InitializeWithContext Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/gl_api_unittest.cc ('k') | ui/gl/gl_gl_api_implementation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_gl_api_implementation.h
diff --git a/ui/gl/gl_gl_api_implementation.h b/ui/gl/gl_gl_api_implementation.h
index 35d040c411da216587545ae9feb323f180ee376d..a5197fed774418c6f6cfe8d338828febd1dfd761 100644
--- a/ui/gl/gl_gl_api_implementation.h
+++ b/ui/gl/gl_gl_api_implementation.h
@@ -62,14 +62,13 @@ class GL_EXPORT RealGLApi : public GLApiBase {
void InitializeWithCommandLine(DriverGL* driver,
base::CommandLine* command_line);
- void InitializeWithContext();
-
void glGetIntegervFn(GLenum pname, GLint* params) override;
const GLubyte* glGetStringFn(GLenum name) override;
const GLubyte* glGetStringiFn(GLenum name, GLuint index) override;
- private:
void InitializeFilteredExtensions();
+
+ private:
void glFinishFn() override;
void glFlushFn() override;
@@ -77,6 +76,10 @@ class GL_EXPORT RealGLApi : public GLApiBase {
std::vector<std::string> disabled_exts_;
std::vector<std::string> filtered_exts_;
std::string filtered_exts_str_;
+
+#if DCHECK_IS_ON()
+ bool filtered_exts_initialized_;
+#endif
};
// Inserts a TRACE for every GL call.
« no previous file with comments | « ui/gl/gl_api_unittest.cc ('k') | ui/gl/gl_gl_api_implementation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698