Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: android_webview/native/aw_pdf_exporter.h

Issue 1253423003: [Android WebView] Don't store unnecessary copy of print_settings in aw_pdf_exporter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/native/aw_pdf_exporter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/aw_pdf_exporter.h
diff --git a/android_webview/native/aw_pdf_exporter.h b/android_webview/native/aw_pdf_exporter.h
index d9f3a6b01dbea07684199db92f96481c00740aaf..f2513f82b2fde4d952795bd32f7852ced13a1565 100644
--- a/android_webview/native/aw_pdf_exporter.h
+++ b/android_webview/native/aw_pdf_exporter.h
@@ -10,7 +10,6 @@
#include "base/android/jni_weak_ref.h"
#include "base/android/scoped_java_ref.h"
#include "base/basictypes.h"
-#include "base/memory/scoped_ptr.h"
#include "skia/ext/refptr.h"
namespace content {
@@ -37,14 +36,14 @@ class AwPdfExporter {
jobject cancel_signal);
private:
- void CreatePdfSettings(JNIEnv* env, jobject obj);
+ void InitPdfSettings(JNIEnv* env,
+ jobject obj,
+ printing::PrintSettings& settings);
void DidExportPdf(int fd, bool success);
JavaObjectWeakGlobalRef java_ref_;
content::WebContents* web_contents_;
- scoped_ptr<printing::PrintSettings> print_settings_;
-
DISALLOW_COPY_AND_ASSIGN(AwPdfExporter);
};
« no previous file with comments | « no previous file | android_webview/native/aw_pdf_exporter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698