Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1253423003: [Android WebView] Don't store unnecessary copy of print_settings in aw_pdf_exporter. (Closed)

Created:
5 years, 4 months ago by timvolodine
Modified:
5 years, 4 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Don't store unnecessary copy of print_settings in aw_pdf_exporter. There is no need to keep a copy of the print_settings in aw_pdf_exporter anymore because it is owned by AwPrintManager now. BUG=465802 Committed: https://crrev.com/d72d37dfbf6a2c2a7417ce6a6ed5d6231de096a7 Cr-Commit-Position: refs/heads/master@{#342340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M android_webview/native/aw_pdf_exporter.h View 2 chunks +3 lines, -4 lines 0 comments Download
M android_webview/native/aw_pdf_exporter.cc View 4 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
timvolodine
5 years, 4 months ago (2015-07-27 17:16:34 UTC) #2
sgurun-gerrit only
so settings logic was broken then, no?
5 years, 4 months ago (2015-07-27 18:02:15 UTC) #3
timvolodine
On 2015/07/27 18:02:15, sgurun wrote: > so settings logic was broken then, no? During the ...
5 years, 4 months ago (2015-07-27 18:19:48 UTC) #4
sgurun-gerrit only
lgtm
5 years, 4 months ago (2015-07-27 23:26:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253423003/1
5 years, 4 months ago (2015-08-07 12:45:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 13:05:31 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 13:06:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d72d37dfbf6a2c2a7417ce6a6ed5d6231de096a7
Cr-Commit-Position: refs/heads/master@{#342340}

Powered by Google App Engine
This is Rietveld 408576698