Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 1253403005: Implement CSS.escape (Closed)

Created:
5 years, 4 months ago by rwlbuis
Modified:
5 years, 3 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, vivekg_samsung, blink-reviews-css, vivekg, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Implement CSS.escape Implement CSS.escape method as specified in [1]. In order to support this use serializeIdentifier. Note that serializeIdentifier is modified to return a boolean since if it fails we need to throw an exception. Add a layout test based on [2]. serializeIdentifier was changed to fix these tests. BUG=331218 [1] https://drafts.csswg.org/cssom/#the-css.escape()-method [2] https://github.com/mathiasbynens/CSS.escape Committed: https://crrev.com/81430c372a9a97e91a9a95580611b9b3f1cc4ece git-svn-id: svn://svn.chromium.org/blink/trunk@199580 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Fix more tests #

Patch Set 3 : Fix final test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -14 lines) Patch
A LayoutTests/css3/escape-dom-api.html View 1 2 1 chunk +75 lines, -0 lines 0 comments Download
A LayoutTests/css3/escape-dom-api-expected.txt View 1 1 chunk +60 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/parsing-css-nonascii.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/parsing-css-nonascii-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/selector-text-escape.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSS.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSMarkup.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSMarkup.cpp View 1 2 3 chunks +10 lines, -4 lines 0 comments Download
M Source/core/css/DOMWindowCSS.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/DOMWindowCSS.cpp View 2 chunks +14 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSParserToken.cpp View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rwlbuis
PTAL
5 years, 4 months ago (2015-07-27 23:25:05 UTC) #2
Timothy Loh
On 2015/07/27 23:25:05, rwlbuis wrote: > PTAL lgtm (FF has the same output for the ...
5 years, 4 months ago (2015-07-28 04:47:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253403005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253403005/40001
5 years, 4 months ago (2015-07-28 13:40:50 UTC) #5
rwlbuis
On 2015/07/28 04:47:12, Timothy Loh wrote: > On 2015/07/27 23:25:05, rwlbuis wrote: > > PTAL ...
5 years, 4 months ago (2015-07-28 13:42:02 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199580
5 years, 4 months ago (2015-07-28 14:52:24 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:50:48 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/81430c372a9a97e91a9a95580611b9b3f1cc4ece

Powered by Google App Engine
This is Rietveld 408576698