ozone gbm: whitelist 3 DRM ioctl code for native GpuMemoryBuffer.

sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <fcntl.h>
 #include <linux/net.h>
@@ skipping 17 matching lines @@
 #include "sandbox/linux/bpf_dsl/seccomp_macros.h"
 #include "sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.h"
 #include "sandbox/linux/seccomp-bpf/sandbox_bpf.h"
 #include "sandbox/linux/system_headers/linux_futex.h"
 #include "sandbox/linux/system_headers/linux_syscalls.h"
 #include "sandbox/linux/system_headers/linux_time.h"
 
 // PNaCl toolchain does not provide sys/ioctl.h header.
 #if !defined(OS_NACL_NONSFI)
 #include <sys/ioctl.h>
+#if defined(USE_VGEM_MAP)
+#include <libdrm/vgem_drm.h>
+#endif
 #endif
 
 #if defined(OS_ANDROID)
 
 #if !defined(F_DUPFD_CLOEXEC)
 #define F_DUPFD_CLOEXEC (F_LINUX_SPECIFIC_BASE + 6)
 #endif
 
 // https://android.googlesource.com/platform/bionic/+/lollipop-release/libc/private/bionic_prctl.h
 #if !defined(PR_SET_VMA)
@@ skipping 95 matching lines @@
   return Switch(option)
       .CASES((PR_GET_NAME, PR_SET_NAME, PR_GET_DUMPABLE, PR_SET_DUMPABLE),
              Allow())
 #if defined(OS_ANDROID)
       .CASES((PR_SET_VMA, PR_SET_TIMERSLACK_PID), Allow())
 #endif
       .Default(CrashSIGSYSPrctl());
 }
 
 ResultExpr RestrictIoctl() {
-  const Arg<int> request(1);
-  return Switch(request).CASES((TCGETS, FIONREAD), Allow()).Default(
-      CrashSIGSYSIoctl());
+  const Arg<unsigned int> request(1);
+  return Switch(request)
+      .CASES((static_cast<unsigned int>(TCGETS), FIONREAD), Allow())

[spang, 2015/08/21 17:28:51]

Why unsigned int rather than unsigned long? The actual parameter type is
"unsigned long".

[mdempsky, 2015/08/21 17:39:47]

Annoying.  POSIX and the Linux man pages say request is an "int", but Linux
<sys/ioctl.h> uses "unsigned long int".

FWIW, the consequence of Arg<32-bit> vs Arg<64-bit> here is whether the compiled
BPF program will include extra checks to reject "impossible" 64-bit arguments
(by crashing).  But since the default case is to crash anyway, there's not much
practical consequence.

[dshwang, 2015/08/21 18:26:33]

Thx for investigation. I rollback this code to ensure both POSIX and Linux.

+#if defined(USE_VGEM_MAP)
+      .CASES((DRM_IOCTL_GEM_CLOSE, DRM_IOCTL_VGEM_MODE_MAP_DUMB,
+              DRM_IOCTL_PRIME_FD_TO_HANDLE),
+             Allow())
+#endif
+      .Default(CrashSIGSYSIoctl());
 }
 
 ResultExpr RestrictMmapFlags() {
   // The flags you see are actually the allowed ones, and the variable is a
   // "denied" mask because of the negation operator.
   // Significantly, we don't permit MAP_HUGETLB, or the newer flags such as
   // MAP_POPULATE.
   // TODO(davidung), remove MAP_DENYWRITE with updated Tegra libraries.
   const uint64_t kAllowedMask = MAP_SHARED | MAP_PRIVATE | MAP_ANONYMOUS |
                                 MAP_STACK | MAP_NORESERVE | MAP_FIXED |
@@ skipping 144 matching lines @@
                  clockid == CLOCK_MONOTONIC ||
                  clockid == CLOCK_MONOTONIC_COARSE ||
                  clockid == CLOCK_PROCESS_CPUTIME_ID ||
                  clockid == CLOCK_REALTIME ||
                  clockid == CLOCK_REALTIME_COARSE ||
                  clockid == CLOCK_THREAD_CPUTIME_ID,
              Allow()).Else(CrashSIGSYS());
 }
 
 }  // namespace sandbox.