Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

Issue 1253343002: [XHR] Tidy up files for testing XHR's error for mixed content check failure (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add expected file Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-async-xhr-post.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
index b23c717a45f319e27090a277e3120d419010aff0..635b9209da8a8940ddfb7c2e90e9e68186fc574a 100644
--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
@@ -838,7 +838,7 @@ void DocumentThreadableLoader::loadRequest(const ResourceRequest& request, Resou
if (!resource()) {
ThreadableLoaderClient* client = m_client;
clear();
- client->didFail(ResourceError(errorDomainBlinkInternal, 0, requestURL.string(), "Failed to start loading."));
+ client->didFail(ResourceError(errorDomainBlinkInternal, 0, requestURL.string(), "Failed to start loading"));
hiroshige 2016/02/25 16:45:07 nit: should we remove period in the messages? Some
tyoshino (SeeGerritForStatus) 2016/02/25 23:33:06 Woo. Sorry for my bad. I just failed to revert it
// |this| may be dead here.
return;
}
@@ -847,6 +847,7 @@ void DocumentThreadableLoader::loadRequest(const ResourceRequest& request, Resou
unsigned long identifier = resource()->identifier();
InspectorInstrumentation::documentThreadableLoaderStartedLoadingForClient(m_document, identifier, m_client);
}
+
return;
}
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-async-xhr-post.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698