[XHR] Tidy up files for testing XHR's error for mixed content check failure

third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
index b23c717a45f319e27090a277e3120d419010aff0..a7bc18c26725cb7c94e203dddcf9648cd5a86c04 100644
--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
@@ -838,7 +838,7 @@ void DocumentThreadableLoader::loadRequest(const ResourceRequest& request, Resou
         if (!resource()) {
             ThreadableLoaderClient* client = m_client;
             clear();
-            client->didFail(ResourceError(errorDomainBlinkInternal, 0, requestURL.string(), "Failed to start loading."));
+            client->didFail(ResourceError(errorDomainBlinkInternal, 0, requestURL.string(), "Failed to start a loader"));

[hiroshige, 2016/02/22 15:45:46]

This CL doesn't contain -expected.txt diffs. Does it mean that there is no
layout tests that cover this statement and we should add one? (Most of the XHR
tests is written by js-test.js and has -expected.txt)

nit: What is the reason for this message change? I'm not sure what "a loader"
means for JavaScript developers.

[tyoshino (SeeGerritForStatus), 2016/02/25 08:11:24]

I was misunderstanding that a test can be without -expected.txt only when
there's no CONSOLE message. But it's not. Sorry. We really need a -expected.txt
file for this test to verify the printed message.
Good point. I updated this for clarifying internal cause, but this is used for
printing a console message. I wasn't aware of that when making this change.

I think providing additional and internal details in a console message is not
bad (useful when included in a user bug report). Let's refine
RawResource::fetchMedia(), etc. in a separate CL to allow
DocumentThreadbleLoader to get detailed error info from ResourceFetcher and
translate that to a user friendly message.

Reverted.

             // |this| may be dead here.
             return;
         }
@@ -847,6 +847,7 @@ void DocumentThreadableLoader::loadRequest(const ResourceRequest& request, Resou
             unsigned long identifier = resource()->identifier();
             InspectorInstrumentation::documentThreadableLoaderStartedLoadingForClient(m_document, identifier, m_client);
         }
+
         return;
     }