Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/task.dart

Issue 1253333002: dart2js cps: Support async/await by rewriting the JavaScript AST. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Add issue number to status file. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/task.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/task.dart b/pkg/compiler/lib/src/js_backend/codegen/task.dart
index 14cc633582ddab1c59fb77b351d27f1dcd54554d..d784197b177673efbf2cfc3424983d78a736760d 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/task.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/task.dart
@@ -34,6 +34,7 @@ import '../../cps_ir/cps_ir_nodes_sexpr.dart';
class CpsFunctionCompiler implements FunctionCompiler {
final ConstantSystem constantSystem;
+ // TODO(karlklose): remove the compiler.
final Compiler compiler;
final Glue glue;
final SourceInformationStrategy sourceInformationFactory;
@@ -56,6 +57,8 @@ class CpsFunctionCompiler implements FunctionCompiler {
String get name => 'CPS Ir pipeline';
+ JavaScriptBackend get backend => compiler.backend;
+
/// Generates JavaScript code for `work.element`.
js.Fun compile(CodegenWorkItem work) {
AstElement element = work.element;
@@ -213,7 +216,13 @@ class CpsFunctionCompiler implements FunctionCompiler {
js.Fun compileToJavaScript(CodegenWorkItem work,
tree_ir.FunctionDefinition definition) {
CodeGenerator codeGen = new CodeGenerator(glue, work.registry);
- return attachPosition(codeGen.buildFunction(definition), work.element);
+ Element element = work.element;
+ js.Fun code = codeGen.buildFunction(definition);
+ if (element is FunctionElement && element.asyncMarker != AsyncMarker.SYNC) {
+ code = backend.rewriteAsync(element, code);
+ work.registry.registerAsyncMarker(element);
+ }
+ return attachPosition(code, element);
}
Iterable<CompilerTask> get tasks {

Powered by Google App Engine
This is Rietveld 408576698