PDF: add support for named destinations.

PDF: add support for named destinations.

Landing patchset 7 from https://codereview.appspot.com/7374052 for dml@google.com
Committed: https://code.google.com/p/skia/source/detail?r=8034

[epoger, 2013-03-06 15:51:18]

I have launched tries on a sampling of the bots that failed in
https://codereview.chromium.org/12466008/ :

tools/submit_try pdf --bot Skia_Shuttle_Win7_Intel_Float_Debug_32
Skia_Shuttle_Win7_Intel_Float_DirectWrite_Debug_32 Skia_Mac_Float_Debug_32 -r
8005

These two have already started:
http://70.32.156.53:10117/builders/Skia_Shuttle_Win7_Intel_Float_DirectWrite_...
http://70.32.156.53:10117/builders/Skia_Mac_Float_Debug_32_Trybot/builds/17

This one hasn't started yet, but I think this will be the link:
http://70.32.156.53:10117/builders/Skia_Shuttle_Win7_Intel_Float_Debug_32_Try...

[epoger, 2013-03-06 16:10:49]

On 2013/03/06 15:51:18, epoger wrote:
> I have launched tries on a sampling of the bots that failed in
> https://codereview.chromium.org/12466008/ :

Two of the trybots already failed with errors like this:

/Users/chrome-bot/skia-buildbot/skiabot-macmini-10_6-003/buildbot/third_party/chromium_buildbot/slave/Skia_Mac_Float_Debug_32_Trybot/build/trunk/gyp/../gm/internal_links.cpp:
In member function 'virtual void skiagm::InternalLinksGM::onDraw(SkCanvas*)':
/Users/chrome-bot/skia-buildbot/skiabot-macmini-10_6-003/buildbot/third_party/chromium_buildbot/slave/Skia_Mac_Float_Debug_32_Trybot/build/trunk/gyp/../gm/internal_links.cpp:48:
warning: passing 'SkScalar' for argument 3 to 'void
skiagm::InternalLinksGM::drawLabeledRect(SkCanvas*, const char*, int, int)'
/Users/chrome-bot/skia-buildbot/skiabot-macmini-10_6-003/buildbot/third_party/chromium_buildbot/slave/Skia_Mac_Float_Debug_32_Trybot/build/trunk/gyp/../gm/internal_links.cpp:48:
warning: passing 'SkScalar' for argument 4 to 'void
skiagm::InternalLinksGM::drawLabeledRect(SkCanvas*, const char*, int, int)'

I'm working on a fix.

[epoger, 2013-03-06 16:21:46]

On 2013/03/06 16:10:49, epoger wrote:
> On 2013/03/06 15:51:18, epoger wrote:
> > I have launched tries on a sampling of the bots that failed in
> > https://codereview.chromium.org/12466008/ :
> 
> Two of the trybots already failed with errors like this:
> 
>
/Users/chrome-bot/skia-buildbot/skiabot-macmini-10_6-003/buildbot/third_party/chromium_buildbot/slave/Skia_Mac_Float_Debug_32_Trybot/build/trunk/gyp/../gm/internal_links.cpp:
> In member function 'virtual void skiagm::InternalLinksGM::onDraw(SkCanvas*)':
>
/Users/chrome-bot/skia-buildbot/skiabot-macmini-10_6-003/buildbot/third_party/chromium_buildbot/slave/Skia_Mac_Float_Debug_32_Trybot/build/trunk/gyp/../gm/internal_links.cpp:48:
> warning: passing 'SkScalar' for argument 3 to 'void
> skiagm::InternalLinksGM::drawLabeledRect(SkCanvas*, const char*, int, int)'
>
/Users/chrome-bot/skia-buildbot/skiabot-macmini-10_6-003/buildbot/third_party/chromium_buildbot/slave/Skia_Mac_Float_Debug_32_Trybot/build/trunk/gyp/../gm/internal_links.cpp:48:
> warning: passing 'SkScalar' for argument 4 to 'void
> skiagm::InternalLinksGM::drawLabeledRect(SkCanvas*, const char*, int, int)'
> 
> I'm working on a fix.

Try, try again:

tools/submit_try pdf --bot Skia_Mac_Float_Debug_32 -r 8005
http://70.32.156.53:10117/builders/Skia_Mac_Float_Debug_32_Trybot/builds/18

[epoger, 2013-03-06 18:28:01]

> Try, try again:
> 
> tools/submit_try pdf --bot Skia_Mac_Float_Debug_32 -r 8005
> http://70.32.156.53:10117/builders/Skia_Mac_Float_Debug_32_Trybot/builds/18

That one succeeded, so trying 2 more:

tools/submit_try pdf --bot Skia_Shuttle_Win7_Intel_Float_Debug_32
Skia_Shuttle_Win7_Intel_Float_DirectWrite_Debug_32 -r 8005

This one already started:
http://70.32.156.53:10117/builders/Skia_Shuttle_Win7_Intel_Float_DirectWrite_...

This one will run later:
http://70.32.156.53:10117/builders/Skia_Shuttle_Win7_Intel_Float_Debug_32_Try...

[epoger, 2013-03-06 19:57:04]

On 2013/03/06 18:28:01, epoger wrote:
> > Try, try again:

This one succeeded:
http://70.32.156.53:10117/builders/Skia_Shuttle_Win7_Intel_Float_Debug_32_Try...

This one failed, but in the DownloadBaselines step that has nothing to do with
the code itself:
http://70.32.156.53:10117/builders/Skia_Shuttle_Win7_Intel_Float_DirectWrite_...

So I think it's now safe to commit... I will commit it first thing tomorrow
morning, when the tree is a bit quieter.

[epoger, 2013-03-08 09:09:15]

Committed patchset #2 manually as r8034 (presubmit successful).