Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1253273003: Unify casing of function names in devtools. (Closed)

Created:
5 years, 4 months ago by ppi
Modified:
5 years, 4 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Unmove configure_sky. #

Patch Set 3 : Update tests. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -59 lines) Patch
M mojo/devtools/common/devtoolslib/android_shell.py View 10 chunks +13 lines, -13 lines 0 comments Download
M mojo/devtools/common/devtoolslib/http_server.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/devtools/common/devtoolslib/linux_shell.py View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell_arguments.py View 1 14 chunks +24 lines, -25 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell_arguments_unittest.py View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M mojo/devtools/common/mojo_run View 1 4 chunks +10 lines, -11 lines 0 comments Download
M mojo/devtools/common/mojo_test View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ppi
Hi Ben, ptal.
5 years, 4 months ago (2015-07-29 09:14:03 UTC) #1
ppi
ptal
5 years, 4 months ago (2015-07-29 09:54:32 UTC) #2
qsr
On 2015/07/29 09:54:32, ppi wrote: > ptal The tests are failing.
5 years, 4 months ago (2015-07-29 10:05:59 UTC) #3
ppi
updated the tests, ptal. Weirdly enough, some bots fail to apply the patch now though ...
5 years, 4 months ago (2015-07-29 11:16:01 UTC) #7
qsr
lgtm
5 years, 4 months ago (2015-07-29 11:28:13 UTC) #8
ppi
5 years, 4 months ago (2015-07-29 12:10:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:110001) manually as
e82a5ac19729938ea09fe10117b18cb24fb68c8e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698