service/rawdatastore/datastore_key_test.go - Issue 1253263002: Make rawdatastore API safer for writing filters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/rawdatastore/datastore_key_test.go

Issue 1253263002: Make rawdatastore API safer for writing filters. (Closed) Base URL: https://github.com/luci/gae.git@master

Patch Set: fix comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: service/rawdatastore/datastore_key_test.go

diff --git a/service/rawdatastore/datastore_key_test.go b/service/rawdatastore/datastore_key_test.go

index 8bb1fc16f7bff704ffebbe3c9c7fae10d208cf42..4d9586f69548741b2ba526ce25fe625fed7ab5da 100644

--- a/service/rawdatastore/datastore_key_test.go

+++ b/service/rawdatastore/datastore_key_test.go

@@ -142,8 +142,7 @@ func TestBadKeyEncode(t *testing.T) {

})

Convey("invalid", func() {

- So(KeyValid(mkKey("aid", "ns", "hat", "face", "__kind__", 1), "ns", true), ShouldBeTrue)

- So(KeyValid(mkKey("aid", "ns", "hat", "face", "kind", 1), "wat", false), ShouldBeFalse)

+ So(KeyValid(mkKey("aid", "ns", "hat", "face", "__kind__", 1), true, "aid", "ns"), ShouldBeTrue)

bads := []Key{

nil,

@@ -160,7 +159,7 @@ func TestBadKeyEncode(t *testing.T) {

s = k.String()

}

Convey(s, func() {

- So(KeyValid(k, "ns", false), ShouldBeFalse)

+ So(KeyValid(k, false, "aid", "ns"), ShouldBeFalse)

})

}

})

« no previous file with comments | « service/rawdatastore/datastore_key.go ('k') | service/rawdatastore/interface.go » ('j') | no next file with comments »