Make rawdatastore API safer for writing filters.

impl/dummy/dummy.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package dummy
 
 import (
         "fmt"
         "runtime"
         "strings"
@@ skipping 46 matching lines @@
                 }
         }
 
         return fmt.Errorf(niFmtStr, iface, funcName)
 }
 
 /////////////////////////////////// rds ////////////////////////////////////
 
 type rds struct{}
 
-func (rds) NewKey(string, string, int64, rawdatastore.Key) rawdatastore.Key              { panic(ni()) }
-func (rds) DecodeKey(string) (rawdatastore.Key, error)                                   { panic(ni()) }
-func (rds) KeyFromTokens(a, n string, t []rawdatastore.KeyTok) (rawdatastore.Key, error) { panic(ni()) }
-func (rds) Put(rawdatastore.Key, rawdatastore.PropertyLoadSaver) (rawdatastore.Key, error) {
+func (rds) NewKey(kind string, sid string, iid int64, par rawdatastore.Key) rawdatastore.Key {
+        return rawdatastore.NewKey("dummy~appid", "", kind, sid, iid, par)
+}
+func (rds) DecodeKey(string) (rawdatastore.Key, error) { panic(ni()) }
+func (rds) PutMulti([]rawdatastore.Key, []rawdatastore.PropertyLoadSaver, rawdatastore.PutMultiCB) error {
         panic(ni())
 }
-func (rds) Get(rawdatastore.Key, rawdatastore.PropertyLoadSaver) error { panic(ni()) }
-func (rds) Delete(rawdatastore.Key) error                              { panic(ni()) }
-func (rds) PutMulti([]rawdatastore.Key, []rawdatastore.PropertyLoadSaver) ([]rawdatastore.Key, error) {
-        panic(ni())
-}
-func (rds) GetMulti([]rawdatastore.Key, []rawdatastore.PropertyLoadSaver) error { panic(ni()) }
-func (rds) DeleteMulti([]rawdatastore.Key) error                                { panic(ni()) }
-func (rds) NewQuery(string) rawdatastore.Query                                  { panic(ni()) }
-func (rds) Run(rawdatastore.Query) rawdatastore.Iterator                        { panic(ni()) }
-func (rds) GetAll(rawdatastore.Query, *[]rawdatastore.PropertyMap) ([]rawdatastore.Key, error) {
-        panic(ni())
-}
-func (rds) Count(rawdatastore.Query) (int, error) { panic(ni()) }
+func (rds) GetMulti([]rawdatastore.Key, rawdatastore.GetMultiCB) error       { panic(ni()) }
+func (rds) DeleteMulti([]rawdatastore.Key, rawdatastore.DeleteMultiCB) error { panic(ni()) }
+func (rds) NewQuery(string) rawdatastore.Query                               { panic(ni()) }
+func (rds) Run(rawdatastore.Query, rawdatastore.RunCB) error                 { panic(ni()) }
 func (rds) RunInTransaction(func(context.Context) error, *rawdatastore.TransactionOptions) error {
         panic(ni())
 }
 
 var dummyRDSInst = rds{}
 
 // RawDatastore returns a dummy rawdatastore.Interface implementation suitable
 // for embedding. Every method panics with a message containing the name of the
 // method which was unimplemented.
 func RawDatastore() rawdatastore.Interface { return dummyRDSInst }
@@ skipping 44 matching lines @@
 // TaskQueue returns a dummy taskqueue.Interface implementation suitable for
 // embedding.  Every method panics with a message containing the name of the
 // method which was unimplemented.
 func TaskQueue() taskqueue.Interface { return dummyTQInst }
 
 /////////////////////////////////// i ////////////////////////////////////
 
 type i struct{}
 
 func (i) AccessToken(scopes ...string) (token string, expiry time.Time, err error) { panic(ni()) }
-func (i) AppID() string                                                            { panic(ni()) }
+func (i) AppID() string                                                            { return "dummy~appid" }
+func (i) GetNamespace() string                                                     { return "dummy-namespace" }
 func (i) ModuleHostname(module, version, instance string) (string, error)          { panic(ni()) }
 func (i) ModuleName() string                                                       { panic(ni()) }
 func (i) DefaultVersionHostname() string                                           { panic(ni()) }
 func (i) PublicCertificates() ([]info.Certificate, error)                          { panic(ni()) }
 func (i) RequestID() string                                                        { panic(ni()) }
 func (i) ServiceAccount() (string, error)                                          { panic(ni()) }
 func (i) SignBytes(bytes []byte) (keyName string, signature []byte, err error)     { panic(ni()) }
 func (i) VersionID() string                                                        { panic(ni()) }
 func (i) Namespace(namespace string) (context.Context, error)                      { panic(ni()) }
 func (i) Datacenter() string                                                       { panic(ni()) }
 func (i) InstanceID() string                                                       { panic(ni()) }
 func (i) IsDevAppServer() bool                                                     { panic(ni()) }
 func (i) ServerSoftware() string                                                   { panic(ni()) }
 func (i) IsCapabilityDisabled(err error) bool                                      { panic(ni()) }
 func (i) IsOverQuota(err error) bool                                               { panic(ni()) }
 func (i) IsTimeoutError(err error) bool                                            { panic(ni()) }
 
 var dummyInfoInst = i{}
 
 // Info returns a dummy info.Interface implementation suitable for embedding.
 // Every method panics with a message containing the name of the method which
 // was unimplemented.
 func Info() info.Interface { return dummyInfoInst }