Make rawdatastore API safer for writing filters.

impl/dummy/dummy_test.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package dummy
 
 import (
         "testing"
 
         infoS "github.com/luci/gae/service/info"
@@ skipping 15 matching lines @@
 
         Convey("Context Access", t, func() {
                 c := context.Background()
 
                 Convey("blank", func() {
                         So(mcS.Get(c), ShouldBeNil)
                         So(tqS.Get(c), ShouldBeNil)
                         So(infoS.Get(c), ShouldBeNil)
                 })
 
+                // needed for everything else
+                c = infoS.Set(c, Info())
+
+                Convey("Info", func() {
+                        So(infoS.Get(c), ShouldNotBeNil)
+                        So(func() {
+                                defer p()
+                                infoS.Get(c).Datacenter()
+                        }, ShouldPanicWith, "dummy: method Info.Datacenter is not implemented")
+                })
+
                 Convey("RawDatastore", func() {
                         c = rdsS.Set(c, RawDatastore())
                         So(rdsS.Get(c), ShouldNotBeNil)
                         So(func() {
                                 defer p()
-                                rdsS.Get(c).NewKey("", "", 1, nil)
-                        }, ShouldPanicWith, "dummy: method RawDatastore.NewKey is not implemented")
+                                rdsS.Get(c).DecodeKey("wut")
+                        }, ShouldPanicWith, "dummy: method RawDatastore.DecodeKey is not implemented")
                 })
 
                 Convey("Memcache", func() {
                         c = mcS.Set(c, Memcache())
                         So(mcS.Get(c), ShouldNotBeNil)
                         So(func() {
                                 defer p()
                                 mcS.Get(c).Add(nil)
                         }, ShouldPanicWith, "dummy: method Memcache.Add is not implemented")
                 })
 
                 Convey("TaskQueue", func() {
                         c = tqS.Set(c, TaskQueue())
                         So(tqS.Get(c), ShouldNotBeNil)
                         So(func() {
                                 defer p()
                                 tqS.Get(c).Purge("")
                         }, ShouldPanicWith, "dummy: method TaskQueue.Purge is not implemented")
                 })
 
-                Convey("Info", func() {
-                        c = infoS.Set(c, Info())
-                        So(infoS.Get(c), ShouldNotBeNil)
-                        So(func() {
-                                defer p()
-                                infoS.Get(c).Datacenter()
-                        }, ShouldPanicWith, "dummy: method Info.Datacenter is not implemented")
-                })
         })
 }