net/http/http_cache_transaction.cc - Issue 1253173002: revert is_sparse_ "simplification"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_cache_transaction.cc

Issue 1253173002: revert is_sparse_ "simplification" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_cache_transaction.cc

diff --git a/net/http/http_cache_transaction.cc b/net/http/http_cache_transaction.cc

index 77ea96c12ec3f44cd5c71a34df112c7ecc0cb1d4..527dc2df56b54c5c167726a956e2775b3b3d0e61 100644

--- a/net/http/http_cache_transaction.cc

+++ b/net/http/http_cache_transaction.cc

@@ -327,7 +327,7 @@ bool HttpCache::Transaction::AddTruncatedFlag() {

DCHECK(mode_ & WRITE || mode_ == NONE);

// Don't set the flag for sparse entries.

- if (is_sparse_)

+ if (partial_ && !truncated_)

return true;

if (!CanResume(true))

« no previous file with comments | « no previous file | no next file » | no next file with comments »