Try to read BOS and WebUSB descriptors from USB devices.

Try to read BOS and WebUSB descriptors from USB devices.

When a USB 2.1 or higher device is enumerated this patch attempts to
read its binary device object store (BOS) descriptor. If a WebUSB
platform capability descriptor is found the WebUSB landing page and
allowed origin descriptors are requested.

These requests should be safe as the USB 3.0 specification requires
that devices announcing support for version 2.1 (which is just USB 3.0
for non-super-speed devices) or higher must implement the BOS
descriptor request.

BUG=492204
Committed: https://crrev.com/6eb7a8ae9630f17bcb0673c05d983577b8652862
Cr-Commit-Position: refs/heads/master@{#342028}

[Reilly Grant (use Gerrit), 2015-08-03 23:31:08]

reillyg@chromium.org changed reviewers:
+ rockot@chromium.org

[Reilly Grant (use Gerrit), 2015-08-03 23:31:08]

reillyg@chromium.org changed reviewers:
+ rockot@chromium.org

[Reilly Grant (use Gerrit), 2015-08-03 23:56:47]

Please take a look.

[Ken Rockot(use gerrit already), 2015-08-04 01:15:01]

lgtm

https://codereview.chromium.org/1253163005/diff/1/device/usb/usb_service_impl.cc
File device/usb/usb_service_impl.cc (right):

https://codereview.chromium.org/1253163005/diff/1/device/usb/usb_service_impl...
device/usb/usb_service_impl.cc:53: const int kControlTransferTimeout = 60000; /*
1 minute */
nit: a cursory grep through the repo suggests you should use the
two-spaces-and-one-line-comment style rather than /* this */

https://codereview.chromium.org/1253163005/diff/1/device/usb/usb_service_impl...
device/usb/usb_service_impl.cc:343: device_handle->ControlTransfer(
nit: maaaaybe it's worth adding a utility method to UsbDeviceHandle just because
there's a lot of repetition of the same basic control transfer operation (i.e.
read a string descriptor)

https://codereview.chromium.org/1253163005/diff/1/device/usb/usb_service_impl...
device/usb/usb_service_impl.cc:759: bool read_bos_descriptors =
descriptor.bcdUSB >= 0x0210;
nit: add a named constant for 0x210?

[Reilly Grant (use Gerrit), 2015-08-04 20:48:56]

https://codereview.chromium.org/1253163005/diff/1/device/usb/usb_service_impl.cc
File device/usb/usb_service_impl.cc (right):

https://codereview.chromium.org/1253163005/diff/1/device/usb/usb_service_impl...
device/usb/usb_service_impl.cc:53: const int kControlTransferTimeout = 60000; /*
1 minute */
On 2015/08/04 01:15:01, Ken Rockot wrote:
> nit: a cursory grep through the repo suggests you should use the
> two-spaces-and-one-line-comment style rather than /* this */

Done.

https://codereview.chromium.org/1253163005/diff/1/device/usb/usb_service_impl...
device/usb/usb_service_impl.cc:759: bool read_bos_descriptors =
descriptor.bcdUSB >= 0x0210;
On 2015/08/04 01:15:01, Ken Rockot wrote:
> nit: add a named constant for 0x210?

Done.

[Reilly Grant (use Gerrit), 2015-08-05 20:28:10]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2015-08-05 20:28:10]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1253163005/#ps40001
(title: "Resolved Ken's nits.")

[commit-bot: I haz the power, 2015-08-05 20:29:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1253163005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1253163005/40001

[commit-bot: I haz the power, 2015-08-05 20:33:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-05 20:33:42]

Try jobs failed on following builders:
  linux_arm_compile on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_10.10_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_10.1...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Reilly Grant (use Gerrit), 2015-08-05 22:52:46]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2015-08-05 22:52:46]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1253163005/#ps60001
(title: "Rebased.")

[commit-bot: I haz the power, 2015-08-05 22:53:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1253163005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1253163005/60001

[commit-bot: I haz the power, 2015-08-06 00:34:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-06 00:34:53]

Patchset 4 (id:??) landed as
https://crrev.com/6eb7a8ae9630f17bcb0673c05d983577b8652862
Cr-Commit-Position: refs/heads/master@{#342028}